Dependencies view: `getParent` loops forever on untitled documents, extension host runs out of memory

循环位于 vscode/src/dependenciesTree.ts：getParent（约第 55 行）会一直向上回溯，直到遇到路径根；而 activeEditorDidChange（约第 92 行）会无视 scheme 去 reveal 任何活动编辑器的 URI，因此 untitled 文档会被无限回溯。请先阅读这两个函数以及 treeVisibilityDidChange，后者还会 reveal 已记住的 currentVisibleItem。完成的标准是：激活 untitled 编辑器不再触发 reveal 或父节点回溯，并且对于非绝对路径或不前进的父路径，getParent 返回 undefined。

Description

Ruby LSP Information

VS Code Version

1.141.0

Ruby LSP Extension Version

0.10.6

Ruby LSP Server Version

0.26.11

Ruby LSP Add-ons

• Ruby LSP Rails (0.4.8)
• RuboCop (1.86.1)

Ruby Version

3.4.7

Ruby Version Manager

mise

Installed Extensions

Ruby LSP Settings

{}

{
  "enabledFeatures": {
    "codeActions": true,
    "diagnostics": true,
    "documentHighlights": true,
    "documentLink": true,
    "documentSymbols": true,
    "foldingRanges": true,
    "formatting": true,
    "hover": true,
    "inlayHint": true,
    "onTypeFormatting": true,
    "selectionRanges": true,
    "semanticHighlighting": true,
    "completion": false,
    "codeLens": true,
    "definition": true,
    "workspaceSymbol": true,
    "signatureHelp": true,
    "typeHierarchy": true
  },
  "featuresConfiguration": {},
  "addonSettings": {},
  "rubyVersionManager": {
    "identifier": "auto"
  },
  "customRubyCommand": "",
  "formatter": "rubocop_internal",
  "linters": [
    "rubocop_internal"
  ],
  "bundleGemfile": "",
  "testTimeout": 30,
  "pullDiagnosticsOn": "both",
  "useBundlerCompose": false,
  "bypassTypechecker": false,
  "rubyExecutablePath": "sh",
  "indexing": {},
  "erbSupport": true,
  "featureFlags": {},
  "sigOpacityLevel": "1"
}

Also: Remote – Dev Containers on linux-arm64 (Apple Silicon host), explorer.autoReveal left at its default (true). All versions above are the latest stable releases, and the same code is still on main.

Reproduction steps

1. Start the Ruby LSP in VS Code by opening a Rails project.
2. In the Explorer, expand the Dependencies view so its contents are visible.
3. Create an untitled document with File → New Text File (Untitled-N).
4. Click a saved file, then click back to the untitled tab.
5. The extension host's memory starts climbing straight away (591 MB → 1.46 GB in about 20 seconds) until V8 aborts it with JavaScript heap out of memory. The VS Code window hangs in the meantime.

No other extensions are needed. We first hit this through Oracle SQL Developer worksheets, which are also untitled documents.

It also triggers if an untitled editor is active while the Dependencies view is hidden and you then show the view, because currentVisibleItem is remembered and revealed in treeVisibilityDidChange.

Expected: nothing happens, because an untitled document can't be part of any gem.

Code snippet or error message

FATAL ERROR: Ineffective mark-compacts near heap limit Allocation failed - JavaScript heap out of memory
Extension Host Process exited with code: null, signal: SIGABRT.

Heap-allocation profile of the extension host while memory was growing:

-- live allocations by extension
 65.3%  (vscode core)
 34.3%  shopify.ruby-lsp
-- top allocating functions
 49.0%  (vscode core) :: r              extensionHostProcess.js:28
 34.1%  shopify.ruby-lsp :: getParent   extension.js:79
 15.5%  (vscode core) :: (anon)         extensionHostProcess.js:294
  0.3%  (vscode core) :: _resolveParent extensionHostProcess.js:294
  0.3%  (vscode core) :: joinPath       extensionHostProcess.js:28

The cause seems to be in vscode/src/dependenciesTree.ts. activeEditorDidChange (line 92) wraps any active editor's URI in a GemFilePath and reveals it, whatever its scheme. TreeView.reveal then calls getParent (line 55) until it returns undefined, and getParent only stops when parentUri.path === path.parse(parentUri.path).root:

getParent(element: BundlerTreeNode): vscode.ProviderResult<BundlerTreeNode> {
  const parentUri = vscode.Uri.joinPath(element.resourceUri, "..");
  const rootPath = path.parse(parentUri.path).root;

  if (parentUri.path === rootPath) {
    return undefined;
  }
  // ...otherwise returns a gem root or a new GemDirectoryPath(parentUri)
}

For a file: URI the walk ends at /. An untitled document's path has no leading /, so rootPath is "", and joining .. never produces "":

/workspaces/app/db/x.sql -> /workspaces/app/db -> /workspaces/app -> /workspaces -> /   (stops)
Untitled-2               -> . -> .. -> ../.. -> ../../.. -> ../../../.. -> ...         (never stops)

(The trace comes from running the same check with path.posix.join in Node. The profile above matches it.)

Possible fix: skip non-file: URIs in activeEditorDidChange, ideally only revealing URIs under one of gemRootFolders. As a safety net, getParent could return undefined when the parent path isn't absolute or equals the current path:

const uri = editor?.document.uri;
if (!uri || uri.scheme !== "file") {
  return;
}

Workaround: hide the Dependencies view, or set "explorer.autoReveal": false.