Dictionary: update an existing phrase instead of saving conflicting duplicate rules
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
调研方向
Start with Dictionary mutation in Sources/LocalVoice/AppModel.swift, then read the identity and validation logic in CorrectionRule.swift and sequential replacements in TextPrimitives.swift; inspect the Dictionary UI in Views.swift and the related work in #164. Verify the actual add/update route, both Dictionary and Remember validation, and isolated duplicate recovery; done means updates preserve rule identity/order, legacy conflicts require explicit resolution, and native acceptance leaves no fixture in user data.
由索引模型根据 Issue 内容生成。
描述
Outcome and priority
P2 functional defect. Saving a corrected spelling for an existing phrase should update that phrase deliberately, rather than leave two contradictory rules where the old spelling wins.
Evidence
Preview 2.3.0, build 20260928054038, clean source 00be555139f87d4557f48fcffc132b8621c251a2; macOS 26.5.1 (25F80), built-in display. Verified through Copy build details in the running app and bundle metadata.
Source plus an isolated execution of production code: Dictionary Add only trims/checks nonempty and appends (AppModel). A temporary Swift harness used the exact TextPrimitives.swift and CorrectionRule.swift from the installed commit with two synthetic rules:
- qa velcor 928 → VelcorOne928
- QA VELCOR 928 → VelcorTwo928
TextRules.apply returned Please ask VelcorOne928 tomorrow. The later intended spelling was ignored. CorrectionRule.propose for that phrase then returned duplicateRules with count 2.
The worker ran the interpreter in an isolated temporary directory; it did not build/launch Workbench or touch the live dictionary. Parent inspected the exact mutation and rule-application paths. Native inspection additionally found Add enabled for identical Heard and Write text; those unsaved fields were cleared. No real saved rule was added or removed.
Starting points: sequential replacements, Dictionary UI, existing correction validation and identity.
Chosen behaviour
Use the same phrase identity and validation in Dictionary and Remember correction. An exact existing pair is idempotent. A different output for the same case-insensitive phrase shows the current value and an explicit Update action; updating preserves the rule ID and unrelated order.
Legacy contradictory duplicates remain intact until an explicit focused resolution chooses the desired output. Show the conflicting values so people can resolve them without guessing rule order. Do not replay unrelated rules into the current transcript just because a future dictionary rule changed.
Acceptance
- Exact re-adds and changes only to Heard casing do not create duplicate entries. Changes to Write casing can be intentional and offer Update, preserving the exact chosen output.
- Update changes future TextRules output to the chosen spelling and retains rule identity/order.
- Dictionary and Remember correction agree on no-op, newline/control, empty and oversized validation.
- Legacy duplicates can be resolved explicitly without silent deletion of unrelated entries.
- Cover the actual Dictionary mutation route, reusing CorrectionRule logic. Existing CorrectionRuleChecks alone leave addReplacement unprotected.
- Native-test synthetic add/update/duplicate recovery using an isolated disposable library, then verify no fixture remains in the user's data.
- Record signed installed acceptance; the isolated algorithm run is not a native transcription test.
Coordination
Second-pass request under #164. #134 owns discovery/navigation and #15 first dictation; neither covers contradictory saved rules. Share the AppModel implementation owner with Read/recovery changes.
- 主要语言
- Swift
- 星标
- 0
- 派生
- 1
- 平均合并
- 8 小时 16 分钟
- 30 天内合并 PR
- 210
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
Ship-Work/workbench 的其他 Issue
-
bug
难度 2/5 1-3 小时 新手友好度 76/100
维护者通常 1 天内回复
-
bug
难度 2/5 1-3 小时 新手友好度 72/100
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 70/100
维护者通常 1 天内回复
-
documentation good first issue help wanted
难度 2/5 半天 新手友好度 74/100
Ship-Work/workbench#29 · 1 条评论 ·
维护者通常 1 天内回复
-
难度 5/5 一周以上 新手友好度 12/100
维护者通常 1 天内回复
查看 Ship-Work/workbench 的全部 Issue
相似的 Issue
-
swift.md: `Date(myString, strategy: .iso8601)` example omits `try` — the initializer is throwing未关闭
难度 1/5 1 小时以内 新手友好度 88/100
-
core: RAC_LLM_OPTIONS_DEFAULT.min_p disagrees with the IDL's annotated default可能已有人在做 关联的 PR 仍在进行中或已合并。 未关闭bug core p3
难度 2/5 1-3 小时 新手友好度 70/100
RunanywhereAI/runanywhere-sdks#1083 ·
维护者通常 5 天内回复
-
area: docs eco: swift good first issue help wanted lane: free-agent roadmap size: XS type: docs
难度 1/5 1 小时以内 新手友好度 62/100
arminazimi/evergreen#441 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 66/100
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 72/100
nightscout/nightguard#368 ·