[java] LoggingOptionsTest#captureStderrDuring doesn't clean up leaked root-logger handlers

未关闭 适合新手
#17,843 2 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
2/5
预计耗时
1-3 小时
新手友好度
88/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
活跃
技术栈
java
领域
testing

调研方向

打开 java/test/org/openqa/selenium/grid/log/LoggingOptionsTest.java,并将 captureStderrDuring 与已修复的 captureStdOutAndErrDuring helper 进行比较。跟踪临时替换 System.err 前后 root logger 的 handlers,然后运行相关的 LoggingOptionsTest 测试。当 capture 期间添加的 handlers 在 cleanup 期间被移除并关闭,从而防止后续输出受到污染时,即表示完成。

由索引模型根据 Issue 内容生成。

描述

Feature and motivation

Follow-up from #17841 (found by an AI agent while fixing two qodo-code-review findings on that PR's tests, deliberately left out to keep that PR scoped to the findings actually flagged there).

java/test/org/openqa/selenium/grid/log/LoggingOptionsTest.java has two stream-capture helpers: captureStdOutAndErrDuring and captureStderrDuring. LoggingOptions.configureLogging() installs root-logger handlers bound to whatever System.out/System.err are current at call time (via getOutputStream()). If a test temporarily swaps those streams to capture output, those handlers persist after the helper restores the real streams, keep writing into the now-discarded capture buffer, and can pollute later tests/output in the same JVM.

This exact bug was already fixed in captureStdOutAndErrDuring (PR #17841, snapshotting the root logger's handlers before the wrapped action and removing/closing anything added during it), but captureStderrDuring — the simpler, stderr-only variant used by other tests in the same file — was never given the same treatment.

Suggested fix

Mirror captureStdOutAndErrDuring's fix in captureStderrDuring: snapshot LogManager.getLogManager().getLogger("").getHandlers() before swapping System.err, and in the finally block, remove+close any handler that wasn't present in that snapshot.

Context

Found while addressing qodo-code-review findings on #17841 (the same PR that fixed the sibling helper). Not itself flagged by a review comment, so tracked here rather than folded into that PR's scope.

主要语言
Java
星标
34.6k
派生
8.7k
平均合并
1 天 23 小时
30 天内合并 PR
86

环境准备

在 Codespaces 中打开

在浏览器里用你自己的 GitHub 账号启动这个项目的开发容器。

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

SeleniumHQ/selenium 的其他 Issue

查看 SeleniumHQ/selenium 的全部 Issue

相似的 Issue

更多 Java Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。