[🐛 Bug]: Forceful kube-prometheus-stack chart installation even when disabled

未关闭 适合新手
#2,954 16 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
1/5
预计耗时
1 小时以内
新手友好度
78/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
冷清
技术栈
helm, kubernetes
领域
devops

调研方向

从 charts/selenium-grid/Chart.yaml 中 issue 引用的依赖条件开始,检查当 kube-prometheus-stack 的 enabled 值为 false 时该条件是如何评估的。使用提供的 values 验证 chart 依赖行为,并确认禁用时不会安装 kube-prometheus-stack。

由索引模型根据 Issue 内容生成。

描述

needs-triaging
What happened?

When trying to deploy the monitoring exporter for the selenium grid, I found that the helm chart wants to install kube-prometheus-stack chart dependency even when it's enabled flag is set to false.

This is because the dependency check in the helm Chart.yaml is an OR operator instead of an AND: https://github.com/SeleniumHQ/docker-selenium/blob/d9f2777614a95bca9b9660911315d5cd96677070/charts/selenium-grid/Chart.yaml#L24

Command used to start Selenium Grid with Docker (or Kubernetes)
selenium-operator:
  global:
    seleniumGrid:
      imageRegistry: XXXXX
      imageTag: 4.35.0-20250808
      nodesImageTag: 4.35.0-20250808
      kubectlImage: XXXXX
  ingress:
    enabled: false

  basicAuth:
    enabled: false

  autoscaling:
    enableWithExistingKEDA: true
    scalingType: deployment
    scaledOptions:
      minReplicaCount: 1
      maxReplicaCount: 100
      pollingInterval: 5
    #scaledJobOptions:
    #  scalingStrategy:
    #    strategy: default

  # Configuration for isolated components (applied only if `isolateComponents: true`)
  components:
    router:
      nodeSelector:
        grid: "true"

    # Configuration for distributor component
    distributor:
      nodeSelector:
        grid: "true"

    # Configuration for Event Bus component
    eventBus:
      nodeSelector:
        grid: "true"

    # Configuration for Session Map component
    sessionMap:
      nodeSelector:
        grid: "true"

    # Configuration for Session Queue component
    sessionQueue:
      nodeSelector:
        grid: "true"

  # Configuration for selenium hub deployment (applied only if `isolateComponents: false`)
  hub:
    imageTag: 4.35.0-20250808
    imageRegistry: XXXXXXXX
    nameOverride: selenium-operator-hub
    resources:
      requests:
        memory: "8Gi"
        cpu: "1"
      limits:
        memory: "12Gi"
        cpu: "3"
    nodeSelector:
      fanduel.com/spot: utils
    tolerations:
      - key: "fanduel.com/spot"
        operator: "Equal"
        value: "utils"
        effect: "NoSchedule"

  # Configuration for chrome nodes
  chromeNode:
    enabled: true
    deploymentEnabled: true
    replicas: 2
    imageRegistry: XXXXX
    imageTag: 138.0-20250808
    nameOverride: selenium-operator-chrome-node

    resources:
      requests:
        memory: "2Gi"
        cpu: "1"
      limits:
        memory: "3Gi"
        cpu: "1500m"

    nodeSelector:
      fanduel.com/spot: utils
    tolerations:
      - key: "fanduel.com/spot"
        operator: "Equal"
        value: "utils"
        effect: "NoSchedule"

    extraEnvironmentVariables:
      - name: SE_NODE_GRID_URL
        value: ""
      - name: SCREEN_WIDTH
        value: "1600"
      - name: SCREEN_HEIGHT
        value: "900"

    dshmVolumeSizeLimit: 2Gi

    hostAliases:
      - ip: "127.0.0.1"
        hostnames:
          - "api.lab.amplitude.com"

  # Configuration for firefox nodes
  firefoxNode:
    enabled: false

  # Configuration for edge nodes
  edgeNode:
    enabled: false

  kube-prometheus-stack:
    enabled: false
  jaeger:
    enabled: false
    
  monitoring:
    enabled: true
    exporter:
      replicas: 1
      imageRegistry: 077700697743.dkr.ecr.us-east-1.amazonaws.com/docker-hub/ricardbejarano
      imageName: "graphql_exporter"
      imageTag: "v1.2.4"
      port: 9199
      service:
        enabled: true
      annotations:
        prometheus.io/scrape: "true"
        prometheus.io/port: "9199"
Relevant log output
No logs, kube-prometheus-stack is installed
Operating System

EKS

Docker Selenium version (image tag)

4.35.0-20250808

Selenium Grid chart version (chart version)

0.43.2

主要语言
Go
星标
8.7k
派生
2.5k
平均合并
2 天 7 小时
30 天内合并 PR
28

环境准备

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

SeleniumHQ/docker-selenium 的其他 Issue

查看 SeleniumHQ/docker-selenium 的全部 Issue

相似的 Issue

更多 Go Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。