Prepaid: move drawdown maths out of TimeProApiClient; MCP reports a drawdown for non-prepaid invoices
还没有人认领这个 Issue。
评估
- 难度
- 5/5
- 预计耗时
- 一周以上
- 新手友好度
- 45/100
- Issue 类型
- 重构
- 描述清晰度
- 基本清楚
- 活跃度
- 活跃
- 技术栈
- csharp
- 领域
- api, backend-api-design, cli, testing-qa
调研方向
Start by reading TimeProApiClient and the WeekCoverageService, CheckEvaluator, and WeekCheckResult pattern. Trace PrepaidStatusService, PrepaidCalculator, PrepaidStatusResult, and both prepaid CLI and MCP surfaces, then run the existing WireMock coverage and add the zero-rate unit test. Done means the prepaid golden remains byte-identical, both surfaces share the result and fetch, and the contract decision for non-prepaid MCP output is resolved.
由索引模型根据 Issue 内容生成。
描述
Why
Prepaid is the one place where finance rules live in the HTTP client. TimeProApiClient.GetPrepaidStatusSummaryAsync / BuildPrepaidStatusSummary hold the BPP filter, tax-rate normalisation, 3-dp rounding and the credit-note apportioning. Both surfaces call it, but the logic around it has already drifted:
prepaid summaryrefuses a non-prepaid invoice (isPrepaid:false); the MCPGetPrepaidStatustool has no such gate and returns a full drawdown for an ordinary invoice. An agent asked about unspent prepaid credit reports credit that does not exist.- An explicit
SalesTaxPct = 0on a drawdown row is treated as "missing" and replaced with the invoice's rate, so a zero-rated row withSellTotal = 100gains $10 GST. The fallback tests the normalised value against zero instead of testing for null. - The maths can only be tested through WireMock.
Migrate
-
Features/Prepaid/PrepaidStatusServicefor orchestration (invoice, allocated timesheets, credit notes) and a purePrepaidCalculatorfor the maths. - One
PrepaidStatusResult { found, isPrepaid, invoiceId, summary? }used byprepaid summary --jsonandGetPrepaidStatus. -
prepaid statusandGetPrepaidStatusPdfshare the fetch; the adapters only choose file vs base64. - Fix the zero-rate fallback (null means missing, zero means zero) with a unit test.
- Remove the prepaid members from
ITimeProApiClientexcept the raw endpoint calls.
How
Follow WeekCoverageService (fetch) + CheckEvaluator (pure, unit-tested rules) + WeekCheckResult (one document for both surfaces).
Contract
The populated golden (a prepaid invoice) should stay byte-identical. The non-prepaid MCP answer changes shape; ship the gate in a patch only if the old shape can be kept, otherwise hold it for 0.4.0.
Part of #38.
- 主要语言
- C#
- 星标
- 3
- 派生
- 0
- 平均合并
- 11 分钟
- 30 天内合并 PR
- 4
环境准备
在浏览器里用你自己的 GitHub 账号启动这个项目的开发容器。
- 没有 Dockerfile 或 Docker Compose 文件
- 没有 Pull Request 模板
- 没有贡献指南
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
SSWConsulting/TimePro.Tools 的其他 Issue
-
Priority: P3 Type: Refactor
难度 5/5 一周以上 新手友好度 38/100
SSWConsulting/TimePro.Tools#101 ·
-
Priority: P3 Type: Refactor
难度 4/5 3-5 天 新手友好度 42/100
SSWConsulting/TimePro.Tools#100 ·
-
Priority: P3 Type: Refactor
难度 5/5 一周以上 新手友好度 35/100
-
Priority: P2 Type: Refactor
难度 5/5 一周以上 新手友好度 35/100
-
Priority: P2 Type: Bug Type: Refactor
难度 5/5 一周以上 新手友好度 38/100
查看 SSWConsulting/TimePro.Tools 的全部 Issue
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 78/100
unoplatform/uno.check#591 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 75/100
weaviate/csharp-client#378 ·
-
agentic-workflows automated testing
难度 2/5 1-3 小时 新手友好度 85/100
Azure-Samples/Legacy-Modernization-Agents#194 ·
维护者通常 1 天内回复
-
area-encryption area-security p1-recommended technical-debt
难度 2/5 1 小时以内 新手友好度 85/100
维护者通常 1 天内回复
-
bug flaky small
难度 2/5 1-3 小时 新手友好度 70/100
hexide-io/HexIDE#1906 · 1 条评论 ·
维护者通常 1 天内回复