[Lane 2 · kotlin-core] tokenizer.json parity — Metaspace BPE with byte fallback (encode side of #912)
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
- 难度
- 4/5
- 预计耗时
- 1-2 天
- 新手友好度
- 55/100
- Issue 类型
- 功能
- 描述清晰度
- 描述清楚
- 活跃度
- 活跃
- 技术栈
- kotlin
调研方向
Start by reading TokenizerFactory.fromTokenizerJson, QwenByteLevelBpeTokenizer, and the existing bpeMerge implementation; the issue describes the needed Metaspace behavior and dispatch rules. Reuse the byte-token lookup and decode logic in SentencePieceTokenizer, then add the synthetic dispatch test and Moonshine decode fixture in the named tests. Done means the specified fixtures pass on JVM and linuxX64, Qwen tests remain unchanged, and results are reported on #1321.
由索引模型根据 Issue 内容生成。
描述
Sub-issue of #1321 (HF tokenizer.json parity for BPE encoders).
Lane: 2 · Kotlin core
Skill needed: Kotlin, and you should understand BPE merging (the existing bpeMerge in QwenByteLevelBpeTokenizer is 20 lines and is the algorithm). Familiarity with the SentencePiece ▁ convention helps.
Size: m (1–2 days)
Blocked by: the array-merges lane (the mmBERT file does not load without it). Independent of the normalizer lane, but the mmBERT file also declares Replace(" " → "▁"), so run the fixture after both land.
What to do
- Today
TokenizerFactory.fromTokenizerJsonsends everymodel.type: "BPE"file toQwenByteLevelBpeTokenizer, which (a) splits with the GPT-2 regex, (b) maps UTF-8 bytes to the GPT-2 unicode alphabet, (c) merges by rank. Forpre_tokenizer: Metaspacefiles (Llama, Gemma HF exports, mmBERT) steps (a) and (b) are wrong: the alphabet is plain code points with▁for space, and characters missing from the vocab fall back to<0xNN>byte tokens whenmodel.byte_fallbackis true. Every word boundary in the mmBERT file currently becomes id 241753. - Separate the merge-rank BPE core from the alphabet step. Suggested shape: keep
QwenByteLevelBpeTokenizeras the ByteLevel configuration and add aMetaspaceBpeTokenizer(or a strategy parameter) that: replaces" "with▁; honoursprepend_scheme(always→ prepend▁to the text;first→ only to the first segment;never); splits on▁boundaries whensplit: true; runs the same rank-basedbpeMerge; and emits<0xNN>ids for any symbol not in the vocab whenbyte_fallbackis true (fuse_unkotherwise).SentencePieceTokenizeralready has the<0xNN>lookup and decode — reuse, don't copy. - Dispatch in
TokenizerFactory.fromTokenizerJsononpre_tokenizer.type(Metaspace→ new class,ByteLevelor absent → existing class,Sequence→ inspect members). - Decode:
▁→ space,<0xNN>runs → bytes, matching the file'sdecoder: Sequence[Replace, ByteFallback, Fuse]. This is the crash reported in #912 (decode: token '▁Ever' contains non-byte-level char U+2581); add that issue's fixture (decode([18274, 1898, 29973, 2])→"Ever tried?"on the Moonshine v2 file) as a test. - Tests: synthetic Metaspace file in
TokenizerFactoryDispatchTest(3-token vocab, one merge, one<0x..>fallback); then the mmBERT fixture via the Lane 4 goldens. Run./gradlew :skainet-io:skainet-io-core:jvmTest :skainet-io:skainet-io-core:linuxX64Test.
Acceptance
- mmBERT file (multilingual/tokenizer/tokenizer.json) encodes all five #1321 fixture texts identically to the reference; e.g.
"Which department handles this request?"→[12236, 9888, 26446, 736, 3853, 235336] - #912 decode fixture passes on JVM and
linuxX64Test -
bosTokenId/eosTokenIdcome fromadded_tokens(<bos>=2,<eos>=1 in the mmBERT file) - Qwen fixture tests (
QwenByteLevelBpeTokenizerFixtureTest) unchanged - Result reported back on #1321
Notes
If the refactor forces a new public class or changes the Tokenizer interface, stop and say so on #1321 — that trips the SKEEP trigger ("public Kotlin API") and the maintainers decide whether a short SKEEP is needed before the PR. Llama 3 files additionally set ignore_merges: true (vocab lookup of the whole word before merging); note whether you handled it, a follow-up issue is fine.
- 主要语言
- Kotlin
- 星标
- 52
- 派生
- 15
- 平均合并
- 1 天 15 小时
- 30 天内合并 PR
- 36
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 没有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
SKaiNET-developers/SKaiNET 的其他 Issue
-
coding good first issue size:xs skill:kotlin-core sub-issue
难度 2/5 1-3 小时 新手友好度 88/100
SKaiNET-developers/SKaiNET#1323 ·
维护者通常 1 天内回复
-
coding good first issue platform size:xs skill:js sub-issue
难度 2/5 1-3 小时 新手友好度 72/100
SKaiNET-developers/SKaiNET#1232 ·
维护者通常 1 天内回复
-
skeep tracking
难度 5/5 一周以上 新手友好度 15/100
SKaiNET-developers/SKaiNET#1331 ·
维护者通常 1 天内回复
-
assessment size:s skill:review sub-issue
难度 4/5 1-2 天 新手友好度 18/100
SKaiNET-developers/SKaiNET#1330 ·
维护者通常 1 天内回复
-
documentation good first issue size:s skill:docs sub-issue
难度 3/5 1-2 天 新手友好度 78/100
SKaiNET-developers/SKaiNET#1329 ·
维护者通常 1 天内回复
查看 SKaiNET-developers/SKaiNET 的全部 Issue
相似的 Issue
-
bugbane/qf good first issue
难度 2/5 1-3 小时 新手友好度 64/100
osservatorionessuno/bugbane#173 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 78/100
-
Bayern feature:Application ready web
难度 2/5 1-3 小时 新手友好度 67/100
digitalfabrik/entitlementcard#3176 ·
维护者通常 7 天内回复
-
bug need-device
难度 2/5 1-3 小时 新手友好度 64/100
ramesh130/superplayer#495 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 66/100
maxrave-dev/SimpMusic#2649 ·
维护者通常 2 天内回复