Adding rsa dependency introduces non-additive lazy_static feature that breaks other code
还没有人认领这个 Issue。
评估
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 新手友好度
- 35/100
- Issue 类型
- 缺陷
- 描述清晰度
- 基本清楚
- 活跃度
- 停滞
- 技术栈
- rust
调研方向
Start by tracing the rsa to num-bigint-dig to lazy_static dependency chain and reproducing the failure with a non-Send lazy_static value like the example in image.rs. Determine how the non-additive spin_no_std feature is enabled and whether the dependency declarations expose a way to avoid it. Done means the rsa dependency no longer breaks unrelated workspace code and the regression is covered by a reproducible check.
由索引模型根据 Issue 内容生成。
描述
This is the same problem as #219, but since that issue wasn't fully evaluated, I wanted to add my report, with a bit more context.
Dependency chain:
rsadepends onnum-bigint-dignum-bigint-digdepends onlazy_staticwithfeatures = ["spin_no_std"].
lazy_static's spin_no_std feature is non-additive; it causes lazy_static to replace use of std::sync::Once with spin:once::Once. This may seem like a harmless replacement, but:
spin::once::Once<T>has different trait bounds. Namely, it only implementsSyncwhereT: Send + Syncwhilelazy_staticusingstd::sync::Onceonly requiresT: Sync.- This means that anyone using
lazy_staticon a non-Sendtype will see their code break if thespin_no_stdfeature is enabled. - Adding
rsaas a dependency to a large workspace means that every crate in that workspace now gets the modifiedlazy_staticcode usingspinwith stricter trait bounds.
This is currently happening to me: I added rsa to a large workspace, and that change causes compile errors in unrelated (previously working) code:
error[E0277]: `*const u8` cannot be sent between threads safely
--> image.rs:25:1
|
25 | / lazy_static::lazy_static! {
26 | | pub(crate) static ref HELLO_IMAGE: Option<ImageBuffer> = {
27 | | let image_bytes = std::fs::read("hello.png").ok()?;
28 | |
... |
36 | | };
37 | | }
| |_^ `*const u8` cannot be sent between threads safely
I'm not sure how to handle this, but it would be nice if there were a feature in rsa (and num-bigint-dig) to disable this behavior. As it is, I'm unable to add an rsa dependency unless I fork+patch num-bigint-dig.
- 主要语言
- Rust
- 星标
- 673
- 派生
- 190
- PR 合并指标
- 30 天内没有已合并 PR
贡献指南
这个仓库没有索引到贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
RustCrypto/RSA 的其他 Issue
-
难度 2/5 1-3 小时 新手友好度 68/100
RustCrypto/RSA#707 · 2 条评论 · 1 个 reaction ·
-
难度 3/5 半天 新手友好度 74/100
RustCrypto/RSA#703 ·
-
难度 4/5 3-5 天 新手友好度 48/100
RustCrypto/RSA#686 · 4 条评论 ·
-
难度 5/5 一周以上 新手友好度 35/100
RustCrypto/RSA#647 · 9 条评论 · 1 个 reaction ·
-
broken rust docs 未关闭
难度 4/5 3-5 天 新手友好度 35/100
RustCrypto/RSA#641 · 3 个 reaction ·
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 88/100
-
bug core
难度 2/5 1-3 小时 新手友好度 86/100
-
JIT-compiled number -> Decimal conversion silently overflows instead of raising DECIMAL_OVERFLOW 未关闭fuzz
难度 2/5 1-3 小时 新手友好度 82/100
ClickHouse/ClickHouse#122114 ·
-
难度 1/5 1 小时以内 新手友好度 92/100
linebender/vello_svg#90 ·
-
难度 2/5 1-3 小时 新手友好度 74/100