[Bug] 9PFS: unaligned 64-bit loads in Rstat parsing fault on ARMv7-A — any 9P server reply to Tstat causes a kernel data abort (remote DoS)
维护者通常 1 天内回复
评估
- 难度
- 3/5
- 预计耗时
- 半天
- 新手友好度
- 58/100
- Issue 类型
- 缺陷
- 描述清晰度
- 基本清楚
- 活跃度
- 活跃
- 技术栈
- c
调研方向
Start with the P9_OF_OPS_GET macro and get_rx_value64_of() in components/dfs/dfs_v1/filesystems/9pfs/dfs_9pfs.c, then trace their callers at dfs_9pfs_open() and dfs_9pfs_stat(). The report suggests two fixes, a split 32-bit read or an aligned buffer, so pick one and confirm it on the QEMU vexpress-a9 build. Done means the Tstat path no longer faults on ARMv7-A and the 16/32-bit accessors are handled consistently.
由索引模型根据 Issue 内容生成。
描述
RT-Thread Version
master ceef6e0ccd646aef61b907aeb9f29269d1caba50 (2026-10-11, RT-Thread 5.3.1). Also present in v5.3.0. Introduced by 2ffa4f3d60e2374fd06f20d82a7549c4c054a862 ("[DFS] Support 9PFS", merged 2025-12-04); the accessor macros are unchanged since.
Affected area
File systems (DFS)
Hardware/BSP vendor
Not applicable / Other
Architecture
ARM / AArch64
Board and hardware details
config: RT_USING_DFS_V1 + RT_USING_DFS_9PFS + lwIP; 9P over a TCP transport registered via dfs_9pfs_add_tag()
Develop Toolchain
GCC
Describe the bug
get_rx_value64_of() dereferences a plain pointer cast:
/* components/dfs/dfs_v1/filesystems/9pfs/dfs_9pfs.c:48-54 */
#define P9_OF_OPS_GET(width, dir) ... \
rt_uint##width##_t *vp = (void *)&conn->dir##_buffer[idx]; \
return rt_le##width##_to_cpu(*vp);
On ARMv7-A, GCC emits LDRD for this 64-bit load, which requires 8-byte alignment. The buffer layout makes the fault deterministic:
sizeof(struct p9_connection) == 292, andrt_malloc()returns 8-aligned memory, soconn->rx_bufferis always≡ 4 (mod 8);P9_MSG_STAT_LEN == 42, so&rx_buffer[42]is always≡ 6 (mod 8);- therefore every
Tstatreply — including a completely normal, honest one — takes an alignment fault atdfs_9pfs_open()line 623 (fd->vnode->size = get_rx_value64_of(conn, P9_MSG_STAT_LEN)) and atdfs_9pfs_stat()line 1113 (st->st_size), crashing the kernel with a data abort.
Steps to reproduce (full chain under QEMU):
- Build
bsp/qemu-vexpress-a9withRT_USING_DFS_V1=y,RT_USING_DFS_9PFS=y, lwIP enabled, and an application registering a 9p transport + mounting it (dfs_mount(NULL, "/", "9p", 0, "<tag>")). - Run any 9P server that answers
Tversion/Tattachand a syntactically normalRstat(a fully honest server is sufficient — the fault does not depend on malformed content). - Guest: any 9p file operation that reaches a stat, e.g.
open("/<mount>/f")orlsof a directory containing the mount point (msh'slsstats every entry).
Expected behavior: 9P Rstat parsing works on 32-bit ARM targets; unaligned accesses performed safely.
Actual behavior — kernel data abort, thread dump, shutdown loop:
data abort:Execption:
r00:0x600f90f8 r01:0x0000002a r02:0x600f921c r03:0x600f9246 <- r03 = rx_buffer+42 (mod 8 = 6)
...
pc :0x6005a668
6005a660: e1c320d0 ldrd r2, [r3] <- unaligned LDRD -> alignment fault
backtrace:
get_rx_value64_of components/dfs/dfs_v1/filesystems/9pfs/dfs_9pfs.c:84
dfs_9pfs_open components/dfs/dfs_v1/filesystems/9pfs/dfs_9pfs.c:623
dfs_file_open / open / (caller)
(addr2line-verified; the faulting address r03 equals rx_buffer + 42.)
Control run: after mounting, without touching any 9p path (ps, version only) the system keeps running normally — the abort is caused exclusively by the 9pfs stat parsing path.
Other additional context
- Severity: CVSS 3.1
AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:N/A:H(7.5 High, scoped to ARMv7-A + 9pfs deployments), CWE-704 / CWE-125-adjacent (unsafe type reinterpretation). - The same accessor is used with an attacker-walked index in
dfs_9pfs_getdents()(see the companion report aboutcount/stat_sizevalidation), so the 16/32-bit variants should be hardened at the same time — odd offsets are reachable there. - Practical note: 9pfs on 32-bit ARMv7-A boards is therefore unusable today; on aarch64 the equivalent code silently proceeds, which is why this went unnoticed with
qemu-virt64-*/ virtio testing. - Suggested fix — read unaligned-safe (two 32-bit halves, or
__builtin_assume_aligned-free memcpy):
rt_inline rt_uint64_t get_rx_value64_of(struct p9_connection *conn, unsigned idx)
{
rt_uint32_t lo = rt_le32_to_cpu(*(volatile rt_uint32_t *)&conn->rx_buffer[idx]);
rt_uint32_t hi = rt_le32_to_cpu(*(volatile rt_uint32_t *)&conn->rx_buffer[idx + 4]);
return ((rt_uint64_t)hi << 32) | lo;
}
and/or declare rx_buffer/tx_buffer with explicit 8-byte alignment (rt_align(8)).
- Affected versions: master since
2ffa4f3d60(2025-12-04); all releases >= v5.3.0. No fix as of 2026-10-15.
- 主要语言
- C
- 星标
- 12.3k
- 派生
- 5.5k
- 平均合并
- 7 天 9 小时
- 30 天内合并 PR
- 34
环境准备
在浏览器里用你自己的 GitHub 账号启动这个项目的开发容器。
- 没有 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
RT-Thread/rt-thread 的其他 Issue
-
[bsp][stm32][bluepill] README「快速上手」缺少重新生成 MDK 工程这一步,按文档操作无法编译通过可能已有人在做 @moment-NEW 于 14 天前认领。 未关闭in progress
难度 2/5 1-3 小时 新手友好度 75/100
RT-Thread/rt-thread#11818 · 4 条评论 · 已指派 1 人 ·
维护者通常 1 天内回复
-
BSP BSP: Loongson bug RT-Smart
难度 2/5 1-3 小时 新手友好度 72/100
RT-Thread/rt-thread#11717 · 2 条评论 ·
维护者通常 1 天内回复
-
Arch: RISC-V BSP BSP: HPMicro bug
难度 2/5 1-3 小时 新手友好度 72/100
RT-Thread/rt-thread#11687 · 3 条评论 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 68/100
RT-Thread/rt-thread#11472 · 1 条评论 ·
维护者通常 1 天内回复
-
难度 4/5 1-2 天 新手友好度 48/100
RT-Thread/rt-thread#11879 · 1 条评论 ·
维护者通常 1 天内回复
查看 RT-Thread/rt-thread 的全部 Issue
相似的 Issue
-
backlog bug
难度 2/5 1-3 小时 新手友好度 75/100
EchoTools/nevr-runtime#653 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 75/100
InfiniTimeOrg/InfiniTime#2492 ·
-
难度 2/5 1-3 小时 新手友好度 80/100
维护者通常 1 天内回复
-
system: coco
难度 1/5 1 小时以内 新手友好度 90/100
FujiNetWIFI/fujinet-config#274 ·
维护者通常 1 天内回复
-
base-files: 82_config_generate: regenerate /etc/board.json if 0-bytes / truncated after power cut未关闭
难度 2/5 1-3 小时 新手友好度 72/100
openwrt/openwrt#25940 · 5 条评论 ·
维护者通常 1 天内回复