[Bug] FinSH console command lacks asynchronous-safe attribute validation
维护者通常 2 天内回复
评估
这个 Issue 还没有评估数据。
描述
RT-Thread Version
v5.3.0/git-hash: cda0a63ab56d9b46577a58958cb01418e2d668f2
Hardware Type/Architectures
bsp/stm32/stm32f407-atk-explorer
Develop Toolchain
GCC
Describe the bug
Description
In the RT-Thread FinSH component, the console command allows users to dynamically switch the system's log output device at runtime. However, the command's handling logic (and the underlying rt_console_set_device API) only checks if the target device exists, completely failing to validate whether the target device possesses asynchronous-safe attributes or supports interrupt context output (e.g., RT_DEVICE_FLAG_INT_TX).
rt_kprintf is a core logging interface in the RTOS, frequently used within hardware Interrupt Service Routines (ISRs) and low-level kernel assertions. If an attacker or an unaware user redirects the console to a blocking peripheral that internally uses rt_mutex (e.g., I2C, SPI, or certain virtual network devices) via the console command, the system state is "poisoned" (State Poisoning / Type Confusion).
In this state, any subsequent rt_kprintf called from within an ISR (such as a Warning triggered by a peripheral buffer overflow) will trigger the kernel IPC's interrupt safety check assertion. This assertion attempts to print another error using rt_kprintf, causing an infinite recursion and severe memory corruption (Stack Clash), which leads to an instant HardFault (DoS).
Prerequisites to Reproduce
- The FinSH component and the
consolecommand are enabled. - A registered device with blocking lock logic (e.g., a device named
i2c1orspi1) exists in the system.
Steps to Reproduce
- Boot the RT-Thread system and enter the FinSH interactive shell.
- Execute the console redirection command, targeting any slow, blocking device:
msh > console i2c1 - The system state is now poisoned. Next, trigger any code path that calls
rt_kprintforLOG_Wfrom within an ISR (for example, flood the UART with garbage data at a high baud rate to trigger a UART RX Buffer Overflow warning). rt_kprintfroutes the warning to the I2C device, and the I2C driver attempts to acquire anrt_mutexinside the ISR.- The kernel IPC check (
RT_DEBUG_SCHEDULER_AVAILABLE) detects the interrupt context violation and callsrt_kprintfto report the error. - This forms an infinite recursive deadlock between
rt_kprintfand_rt_mutex_take, instantly exhausting stack memory and crashing the device.
Root Cause Analysis (Code Level)
There is a typical device type and attribute validation missing in the source code handling the console command and rt_console_set_device().
The current implementation merely confirms the device exists via rt_device_find(name) and directly switches the pointer:
/* Abstract of the current vulnerable logic */
rt_device_t dev = rt_device_find(name);
if (dev != RT_NULL)
{
rt_console_set_device(name); // Blind switch, no attribute validation
}
### Other additional context
_No response_
- 主要语言
- C
- 星标
- 12.4k
- 派生
- 5.5k
- 平均合并
- 3 天 7 小时
- 30 天内合并 PR
- 79
环境准备
在浏览器里用你自己的 GitHub 账号启动这个项目的开发容器。
- 没有 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
RT-Thread/rt-thread 的其他 Issue
-
Arch: ARM/AArch64 Doc
难度 1/5 1 小时以内 新手友好度 90/100
RT-Thread/rt-thread#12082 · 1 条评论 ·
维护者通常 2 天内回复
-
bug
难度 2/5 1-3 小时 新手友好度 67/100
RT-Thread/rt-thread#11951 · 2 条评论 ·
维护者通常 2 天内回复
-
[Bug] [libc] timer_gettime 拆秒前将总纳秒截断为 uint32_t,剩余时间查询错误可能重新可做 @Yunlk 于 28 天前认领,目前没有进行中的 PR。 未关闭in progress
难度 2/5 1-3 小时 新手友好度 68/100
RT-Thread/rt-thread#11924 · 7 条评论 · 已指派 1 人 ·
维护者通常 2 天内回复
-
[Bug] dfs_v2 tmpfs: ftruncate(fd, 0) frees the file buffer but reports success — use-after-free read/write and double free from a legal POSIX call可能已有人在做 @remukisama 于 33 天前认领。 未关闭in progress
难度 2/5 1-3 小时 新手友好度 78/100
RT-Thread/rt-thread#11902 · 4 条评论 · 已指派 1 人 ·
维护者通常 2 天内回复
-
[bsp][stm32][bluepill] README「快速上手」缺少重新生成 MDK 工程这一步,按文档操作无法编译通过可能重新可做 @moment-NEW 于 50 天前认领,目前没有进行中的 PR。 未关闭in progress
难度 2/5 1-3 小时 新手友好度 75/100
RT-Thread/rt-thread#11818 · 4 条评论 · 已指派 1 人 ·
维护者通常 2 天内回复
查看 RT-Thread/rt-thread 的全部 Issue
相似的 Issue
-
Builder: a structure opened without calculation data shows the Diffraction (fibre) view by default未关闭bug
难度 2/5 1-3 小时 新手友好度 65/100
FriendsofECCE/ECCE#1245 · 1 条评论 ·
-
难度 2/5 1-3 小时 新手友好度 72/100
apache/nuttx-apps#4108 · 4 条评论 ·
维护者通常 1 天内回复
-
bug
难度 1/5 1 小时以内 新手友好度 84/100
VirtualBox/virtualbox#996 ·
维护者通常 6 天内回复
-
难度 1/5 1 小时以内 新手友好度 82/100
trezor/trezor-firmware#8357 ·
维护者通常 2 天内回复
-
难度 2/5 1-3 小时 新手友好度 76/100
维护者通常 1 天内回复