fix(stats): overview polling overlaps ticks, reorders samples and hides errors; one shared polling controller
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 新手友好度
- 42/100
调研方向
Read the five polling implementations named in the issue, starting with lib/core/motion/ticker_gated_polling.dart and the PostgreSQL and MySQL stats views. Trace how each view starts and stops polling and handles tick results, then add tests with a fake clock for non-overlapping ticks, error backoff and recovery, and polling paused by TickerMode. Done when all five views use the shared controller and those behaviors are covered.
由索引模型根据 Issue 内容生成。
描述
Problem
Five Overview/stats screens poll the server with the same copy-pasted code:
| File | Interval | Tick |
|---|---|---|
features/postgresql/postgres_stats_view.dart:185-200 |
5 s | serverStats() |
features/mysql/mysql_stats_view.dart:143-158 |
5 s | serverStats() |
features/redis/redis_view.dart:196-211 |
3 s | INFO |
features/mongodb/mongo_stats_view.dart:168-191 |
3 s default | serverStatus |
features/extensions/extension_stats_view.dart:104-116 |
5 s | JSON-RPC getServerStats |
Each one does Timer.periodic(interval, (_) => unawaited(_onPollTick())) (also in syncTickerGatedPeriodicTimer, lib/core/motion/ticker_gated_polling.dart:23):
- Ticks overlap. A tick does not wait for the previous one. When the server is slow, requests pile up on it exactly when it is struggling. For extension drivers the RPC timeout defaults to 60 s (
extension_driver_session.dart:189-192), so a hung driver collects up to 12 concurrentgetServerStatscalls. - Samples land out of order. Postgres and MySQL append each result to the sparkline history (
_recordHistory) on completion, so overlapping ticks reorder points. - Errors are invisible.
catch (_) {}in every tick: no "stale since" state, no backoff, the dashboard silently freezes on the last good sample. - The timer is started from
build()viasyncTickerGatedPeriodicTimer(a side effect in build), and each view also keeps its own_startTimer.
Fix
One small PollingController (or mixin) in core/motion / core/util:
- self-rescheduling:
await tick()then schedule the next one, so at most one request is in flight; - gated by
TickerMode(keep the current behaviour) andshouldRun; - exponential backoff on errors, last error + last success time exposed as a
ValueListenablefor a "stale" hint; - started and stopped from
didChangeDependencies/dispose, notbuild.
Replace the five copies. Tests with a fake clock: a slow tick never overlaps; errors back off and recover; TickerMode off stops polling.
- 主要语言
- Dart
- 星标
- 23
- 派生
- 1
- 平均合并
- 31 分钟
- 30 天内合并 PR
- 570
环境准备
在浏览器里用你自己的 GitHub 账号启动这个项目的开发容器。
- 没有 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
QueryaHub/Querya-Desktop 的其他 Issue
-
enhancement ui
难度 2/5 1-3 小时 新手友好度 78/100
QueryaHub/Querya-Desktop#1689 ·
维护者通常 1 天内回复
-
ui(dialogs): make destructive query and DML preview dialogs adaptive and prevent table name overflow未关闭bug frontend
难度 2/5 1-3 小时 新手友好度 82/100
QueryaHub/Querya-Desktop#1642 ·
维护者通常 1 天内回复
-
bug error-handling settings
难度 1/5 1-3 小时 新手友好度 78/100
QueryaHub/Querya-Desktop#1637 ·
维护者通常 1 天内回复
-
enhancement
难度 1/5 1 小时以内 新手友好度 88/100
QueryaHub/Querya-Desktop#1636 ·
维护者通常 1 天内回复
-
enhancement marketplace
难度 2/5 1-3 小时 新手友好度 78/100
QueryaHub/Querya-Desktop#1635 ·
维护者通常 1 天内回复
查看 QueryaHub/Querya-Desktop 的全部 Issue
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 82/100
维护者通常 1 天内回复
-
good-first-issue P3
难度 2/5 1-3 小时 新手友好度 88/100
flutter/dart-intellij-third-party#758 ·
维护者通常 1 天内回复
-
Bug: Incorrect location coordinates on logged Sound Meter data可能已有人在做 @Jashan32 今天认领。 未关闭
难度 2/5 1-3 小时 新手友好度 72/100
维护者通常 1 天内回复
-
area/archive bug
难度 2/5 1-3 小时 新手友好度 76/100
DarkFlippers/qUnleashed#374 ·
维护者通常 1 天内回复
-
agent:in-progress agent:ready feature P2 · 中 区域: 悬浮窗
难度 2/5 1-3 小时 新手友好度 85/100
ASDW51/DanmuFloat#178 ·
维护者通常 1 天内回复