GetMarketHours: a late open after the day's last segment keeps the whole day open

已关闭 适合新手
  • 哪里不对？
#9,889 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

@abhi-byte62 已经在做这个了。

开始于 2026年10月15日。

  • #9907 来自 @abhi-byte62 —— 未关闭

评估

难度
2/5
预计耗时
1-3 小时
新手友好度
72/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
活跃
技术栈
csharp
领域
backend, databases

调研方向

从 Common/Securities/SecurityExchangeHours.cs 中 GetMarketHours 的延迟开盘循环开始，并将其索引初始化与上方的提前收盘循环进行比较。使用提供的 Thanksgiving 示例，或针对最后一个片段之后延迟开盘的情况编写一个聚焦测试，重现该问题。完成标准是 GetMarketHours 对该日期不返回任何片段，同时保留所描述的提前收盘行为。

由索引模型根据 Issue 内容生成。

描述

Expected Behavior

When a date's late open falls after every segment of that day, SecurityExchangeHours.GetMarketHours should return no segments for the day (nothing trades before the late open, and the day's sessions have all ended by then).

Actual Behavior

It returns the day's full regular schedule. In the late-open loop (Common/Securities/SecurityExchangeHours.cs, master):

var index = 0;
segmentsLateOpen = new List<MarketHoursSegment>();
for (var i = 0; i < marketHoursSegments.Count; i++)
{
    var segment = marketHoursSegments[i];
    if (segment.Start <= lateOpenTime && lateOpenTime <= segment.End) { ...; index = i + 1; break; }
    else if (lateOpenTime < segment.Start) { index = i; break; }
}
segmentsLateOpen.AddRange(marketHoursSegments.TakeLast(marketHoursSegments.Count - index));

If lateOpenTime is after the last segment's end, neither branch runs, index stays 0, and TakeLast(Count - 0) keeps every segment. So the late open has the opposite of its intended effect.

In the current master market-hours-database.json this happens on 11 entry-dates:

  • Future-cme-LE, Future-cme-GF, Future-cme-HE: 2011-11-24 and 2012-11-22 (Thanksgiving). Each has lateOpens 17:00 and a Thursday regular segment of 08:30-13:05 CT, which is therefore reported open on Thanksgiving.
  • Future-cme-LBR: the same two dates (09:00-15:05 segment).
  • Future-cme-ETH, Future-cme-MET, Future-cme-MBT: 2020-07-03 (lateOpen 17:00 after an 08:30-16:00 segment). These dates are before those contracts listed, so this case is harmless in practice.

None of these dates is in the entry's own holidays list, so the holiday short-circuit does not apply.

Potential Solution

Initialise the late-open index the way the early-close loop just above initialises its own:

var index = marketHoursSegments.Count;   // a late open after every segment leaves nothing to trade

Then TakeLast(0) returns no segments. When an early close precedes such a late open on the same day, the existing segmentsEarlyClose.AddRange(segmentsLateOpen) step still keeps the pre-early-close segments.

(A sibling defect in the early-close loop, index = i - 1 when the early close falls in a gap between segments, was already fixed in #9869. I found it in the same check, then saw the fix on master.)

Reproducing the Problem

Untested sketch. I have not run C# here: the behaviour comes from reading GetMarketHours on master, cross-checked with a line-by-line Python port of it run against master's market-hours-database.json.

var mhdb = MarketHoursDatabase.FromDataFolder();
var hours = mhdb.GetExchangeHours(Market.CME, Symbol.Create("LE", SecurityType.Future, Market.CME), SecurityType.Future);
var thanksgiving = new DateTime(2011, 11, 24, 10, 0, 0);   // exchange-local (America/Chicago), inside 08:30-13:05
Assert.IsFalse(hours.IsOpen(thanksgiving, extendedMarketHours: false));   // expected to fail today: returns true
Assert.IsEmpty(hours.GetMarketHours(thanksgiving).Segments);              // expected to fail today: 1 segment
System Information

Code: master, SecurityExchangeHours.cs as of 82810ea63d55 (2026-10-05, its latest commit). Data: master Data/market-hours/market-hours-database.json, fetched 2026-10-11. OS-independent; this is a logic issue.

Checklist
  • I have completely filled out this template
  • I have confirmed that this issue exists on the current master branch (by code reading and a port run against master data; not by running LEAN)
  • I have confirmed that this is not a duplicate issue by searching issues
  • I have provided detailed steps to reproduce the issue (the test above is a sketch, not run)
主要语言
C#
星标
22.3k
派生
5.4k
平均合并
1 天 23 小时
30 天内合并 PR
53

环境准备

在 Codespaces 中打开

在浏览器里用你自己的 GitHub 账号启动这个项目的开发容器。

从这里开始

  1. 先读完整个 Issue，再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库，在一个分支上完成修改。
  4. 提交 Pull Request，并在描述里引用这个 Issue 编号。

QuantConnect/Lean 的其他 Issue

查看 QuantConnect/Lean 的全部 Issue

相似的 Issue

更多 C# Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。