ExecuteMarginCall can liquidate the same deficit across several groups in one batch

未关闭
  • 哪里不对？
#10,107 2 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

这个 Issue 还没有评估数据。

描述

priority:P1
Description

DefaultMarginCallModel.ExecuteMarginCall can submit multiple liquidations for the same margin deficit within its first execution batch, even when the first pending order would already cover the whole deficit. This is separate from generating duplicate orders for the same group on later scans (#10008).

GetMarginCallOrders sizes every position group's request from the same current portfolio deficit. ExecuteMarginCall submits a group and calls SecurityTransactionManager.WaitForOrder, but ignores its false return when the wait times out. If the order is still open, holdings and MarginRemaining are unchanged, so execution continues to the next group and submits another order covering the same deficit.

In backtesting, MarketOrderFillTimeout is zero, and market orders on daily subscriptions can remain open until the next bar. Thus multiple distinct groups can all be liquidated for the same deficit during a single margin call, even without any subsequent scans.

Reproduction and observed result

Reproduced locally with a temporary NUnit test in MarginCallModelTests, using the existing portfolio/security helpers and FakeOrderProcessor:

  1. Create two distinct USD equity positions, SPY and AAPL, each holding 100 shares at a current price of $100 and leverage 2. Use zero fees and set cash to -$14,000.
  2. Use DefaultMarginCallModel with its default margin buffer and set portfolio.Transactions.MarketOrderFillTimeout = TimeSpan.Zero.
  3. Verify portfolio value is $6,000, maintenance margin is $10,000, and the deficit is $4,000.
  4. Call GetMarginCallOrders, then call ExecuteMarginCall exactly once, leaving submitted orders open.

Observed:

  • Generation returns one request for each group, each selling 81 shares.
  • A single execution submits both requests, returning two tickets.
  • Each sale releases $4,050 of margin at current prices; combined projected relief is $8,100 against a $4,000 deficit.
  • An assertion expecting only one submitted liquidation fails: Expected: 1, But was: 2.

The reproduction fails identically on master (da4d8e4a4) and on 6dd4b06d1; this is a pre-existing execution/sizing problem, not a regression introduced by the pending-ticket guard.

Tested end to end with daily SPY and minute AAPL as well: AAPL's liquidation can fill while a further SPY liquidation is already being submitted from the same unchanged deficit snapshot.

What a fix must achieve

Avoid committing the entire deficit more than once when multiple position groups are processed in one margin call. Continue to allow additional liquidation when pending orders cannot cover the deficit, preserve combo-order grouping, and handle cancellation/rejection without leaving the portfolio indefinitely under-margined.

One possible approach is to account for pending reductions when deciding whether and how much to liquidate from the next group, rather than assuming a timed-out wait means the first liquidation has completed.

主要语言
C#
星标
22.5k
派生
5.4k
平均合并
22 小时 6 分钟
30 天内合并 PR
81

环境准备

在 Codespaces 中打开

在浏览器里用你自己的 GitHub 账号启动这个项目的开发容器。

从这里开始

  1. 先读完整个 Issue，再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库，在一个分支上完成修改。
  4. 提交 Pull Request，并在描述里引用这个 Issue 编号。

QuantConnect/Lean 的其他 Issue

查看 QuantConnect/Lean 的全部 Issue

相似的 Issue

更多 C# Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。