Insider trading readers subtract a day from explicit FileDate timestamps
评估
调研方向
从 QuiverInsiderTrading.cs 和 QuiverInsiderTradingUniverse.cs 中的解析表达式入手,然后检查 issue 中提到的 downloader 序列化。使用提供的行,为两个读取器添加回归测试;更新现有的紧凑格式断言。完成标准是:两个读取器都保留明确提供的 FileDate 时间戳,并且测试通过。
由索引模型根据 Issue 内容生成。
描述
Problem
QuiverInsiderTrading.Reader and QuiverInsiderTradingUniverse.Reader subtract one day from FileDate even when the CSV explicitly supplies the filing timestamp. This makes the reported filing time one day earlier than the stored value, affecting filters and intervals based on FileDate.
This is present on master at b9f250fc550bf963b71a0b0050000f17d23f0c0b; it is independent of legacy column-count handling.
Synthetic reproduction
With a read date of 2026-05-08, parse these current-layout rows using the corresponding readers:
20260508,20260507093000,20260507,P,150.25,100,500,A,D,Example Person,CEO,T,T,F,
AAPL R735QTJ8XC9X,AAPL,20260507093000,20260507,P,150.25,100,500,A,D,Example Person,CEO,T,T,F,
For the per-ticker reader, use an AAPL SubscriptionDataConfig; the universe reader accepts a null config.
Both readers return:
Expected FileDate: 2026-05-07 09:30:00
Actual FileDate: 2026-05-06 09:30:00
Verified with two local NUnit cases against the base readers: both fail with exactly that expected/actual difference.
Cause and required outcome
QuiverInsiderTrading.cs:167andQuiverInsiderTradingUniverse.cs:150on the cited commit apply.AddDays(-1)to the result of the entire parse-or-fallback expression.DataProcessing/QuiverInsiderTradingDataDownloader.cs:119–124serializes a non-omitted filing timestamp directly, without a compensating day offset.FileDateis documented as the time the transaction was filed and became publicly available. The separateTime/EndTimeconvention does not require altering this supplied timestamp.
Preserve explicitly supplied filing timestamps in both readers and add regression coverage. Existing compact-format coverage currently asserts the shifted per-ticker value and will need to reflect the corrected behavior. Suggestion: apply any intended fallback adjustment only to the missing-value branch, not to an explicit timestamp.
Priority is P2 because the verified impact is limited to this metadata field; evidence of broader user impact would raise it.
- 主要语言
- C#
- 星标
- 0
- 派生
- 3
- 平均合并
- 39 分钟
- 30 天内合并 PR
- 4
环境准备
这个项目没有提供开发容器、Dockerfile 或贡献指南,环境需要你自己搭建:先看它的 README,通用步骤见我们的新手贡献指南。
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
QuantConnect/Lean.DataSource.QuiverQuant 的其他 Issue
-
priority:P2
难度 2/5 1-3 小时 新手友好度 88/100
-
priority:P2
难度 4/5 3-5 天 新手友好度 49/100
-
难度 3/5 1-2 天 新手友好度 72/100
查看 QuantConnect/Lean.DataSource.QuiverQuant 的全部 Issue
相似的 Issue
-
clawsweeper:fix-shape-clear clawsweeper:queueable-fix clawsweeper:source-repro impact:ux-friction issue-rating: 🦞 diamond lobster no-stale P2
难度 2/5 1-3 小时 新手友好度 76/100
openclaw/openclaw-windows-node#2287 · 2 条评论 · 1 个 reaction ·
维护者通常 1 天内回复
-
area:host area:operations type:bug
难度 2/5 1-3 小时 新手友好度 78/100
维护者通常 1 天内回复
-
kind:ux needs-triage
难度 2/5 1-3 小时 新手友好度 66/100
elsa-workflows/elsa-foundation#4742 ·
维护者通常 1 天内回复
-
enhancement good first issue help wanted new-language
难度 2/5 1-3 小时 新手友好度 82/100
-
approved area: ui bug
难度 2/5 1-3 小时 新手友好度 78/100
维护者通常 1 天内回复