Compute labor supply response revenue_change instead of preserving legacy zero
还没有人认领这个 Issue。
评估
- 难度
- 5/5
- 预计耗时
- 一周以上
- 新手友好度
- 35/100
- Issue 类型
- 功能
- 描述清晰度
- 基本清楚
- 活跃度
- 冷清
- 技术栈
- python
调研方向
从 calculate_labor_supply_response(...) 开始,并审查 PR #360,以了解现有的 LaborSupplyResponse 输出和 legacy budgetary_impact_lsr 行为。定义 revenue_change 的含义和符号约定,然后确定计算它所需的可用模拟输出。完成标准是:活动运行会产生经过测试的非零影响,非活动运行仍保持为零,并且记录任何 legacy 差异。
由索引模型根据 Issue 内容生成。
描述
Context
PR #360 (Add labor supply response macro output) adds a 4.x-compatible LaborSupplyResponse output that preserves the legacy macro output shape.
As part of that parity work, revenue_change is intentionally set to 0.0 because the legacy API initialized budgetary_impact_lsr to zero and never populated it. That preserves existing public behavior, but it leaves a real fiscal-effect gap: callers may reasonably interpret labor_supply_response.revenue_change as the tax/revenue impact caused by labor-supply responses.
Current behavior
calculate_labor_supply_response(...) computes LSR behavioral quantities such as:
income_lsrsubstitution_lsrtotal_changerelative_lsr- decile average/relative breakdowns
- hours effects where supported
But revenue_change remains hard-coded to 0.0 for both active and inactive LSR paths.
Desired behavior
Determine and implement the correct fiscal calculation for LaborSupplyResponse.revenue_change, rather than preserving the legacy zero.
Acceptance criteria
- Define the intended meaning and sign convention for
revenue_change. - Compute
revenue_changefor active LSR runs using available simulation outputs or clearly documented additional required outputs. - Preserve zero behavior for inactive LSR runs.
- Add focused tests for non-zero revenue effects, zero/inactive behavior, and sign convention.
- Document any intentional divergence from legacy
budgetary_impact_lsrbehavior.
Related PR: #360
- 主要语言
- Python
- 星标
- 7
- 派生
- 9
- 平均合并
- 13 小时 12 分钟
- 30 天内合并 PR
- 11
贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
PolicyEngine/policyengine.py 的其他 Issue
-
难度 2/5 1-3 小时 新手友好度 72/100
PolicyEngine/policyengine.py#473 ·
-
难度 2/5 1-3 小时 新手友好度 68/100
PolicyEngine/policyengine.py#436 · 1 条评论 ·
-
难度 2/5 1-3 小时 新手友好度 72/100
PolicyEngine/policyengine.py#408 ·
-
PolicyEngine/policyengine.py#528 · 已指派 1 人 ·
-
PolicyEngine/policyengine.py#527 · 已指派 1 人 ·
查看 PolicyEngine/policyengine.py 的全部 Issue
相似的 Issue
-
bug
难度 2/5 1-3 小时 新手友好度 75/100
stephrobert/dsoxlab#238 ·
-
难度 2/5 1-3 小时 新手友好度 75/100
-
难度 2/5 1-3 小时 新手友好度 75/100
sublimehq/package_control#1780 ·
-
难度 2/5 1-3 小时 新手友好度 65/100
-
难度 2/5 1-3 小时 新手友好度 70/100
nwg-piotr/nwg-displays#145 ·