Follow up optional documentation and test coverage from PE-US #10937
维护者通常 2 天内回复
还没有人认领这个 Issue。
评估
- 难度
- 2/5
- 预计耗时
- 1-3 小时
- 新手友好度
- 67/100
- Issue 类型
- 文档
- 描述清晰度
- 基本清楚
- 活跃度
- 活跃
- 技术栈
- python, yaml
调研方向
这三处修改都是 YAML:policyengine_us/parameters/gov/states/me/tax/income/credits/fairness/property_tax/rate/excess.yaml 中的 0.5 系数节点、policyengine_us/tests/policy/baseline/gov/states/me/tax/income/credits/property_tax_fairness_credit/me_property_tax_fairness_credit_base_cap.yaml 第 243 行的过时注释,以及 rate/excess.yaml 和 cap.yaml 中的来源标题。先阅读 PR #10937 了解审查背景,在将该节点的日期改为 2014-01-01 之前确认 Maine 5219-KK 的各小节,然后运行 Maine property tax fairness credit 的测试,以表明预期值没有变化。
由索引模型根据 Issue 内容生成。
描述
Follow up the optional P3 findings from PE-US #10937 at 305c1b3aef7af3e3f1e3997ddddf2a3e7b26a055. The existing hard review returned APPROVE with no P0–P2 findings. This issue requests the bounded follow-ups below. It supplies no new policy calculation or expected-value change.
P3-1
policyengine_us/parameters/gov/states/me/tax/income/credits/fairness/property_tax/rate/excess.yaml:3
The first 0.5 factor node starts 2017 while the section applies from 2014. Core backdating already supplies the factor to 2015–2016.
Date the existing 0.5 node 2014-01-01 after confirming source scope; retain all modeled 2015 onward values, 2018 full-excess transition and existing controls. Do not expand eligibility or income coverage.
P3-2
policyengine_us/tests/policy/baseline/gov/states/me/tax/income/credits/property_tax_fairness_credit/me_property_tax_fairness_credit_base_cap.yaml:243
A retained comment says the 50% factor sits outside the amount correction, although the PR now corrects that factor.
Explain that this saturated case checks the cap; the added nonbinding and order cases check the factor. Preserve every input, expected value, margin and case.
P3-3
policyengine_us/parameters/gov/states/me/tax/income/credits/fairness/property_tax/{rate/excess,cap}.yaml
Reference titles cite fewer statutory subsections than the parameter periods cover.
Extend source reference titles to the applicable 5219-KK(2), (2-A), (2-B), (2-C) and (2-D) provisions. Preserve every numerical/date value and source URL unless an independently checked link repair requires a separate change.
Preserve the original review's component, annual-source, full-CI and Axiom-parity limits. Document each resolution against the named source and retain the original validation evidence.
- 主要语言
- Python
- 星标
- 171
- 派生
- 220
- 平均合并
- 4 天 10 小时
- 30 天内合并 PR
- 319
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
PolicyEngine/policyengine-us 的其他 Issue
-
难度 1/5 1 小时以内 新手友好度 85/100
PolicyEngine/policyengine-us#11006 ·
维护者通常 2 天内回复
-
难度 2/5 1-3 小时 新手友好度 70/100
PolicyEngine/policyengine-us#11005 ·
维护者通常 2 天内回复
-
难度 2/5 1-3 小时 新手友好度 65/100
PolicyEngine/policyengine-us#11000 ·
维护者通常 2 天内回复
-
难度 1/5 1 小时以内 新手友好度 88/100
PolicyEngine/policyengine-us#10999 ·
维护者通常 2 天内回复
-
难度 2/5 1-3 小时 新手友好度 66/100
PolicyEngine/policyengine-us#10998 ·
维护者通常 2 天内回复
查看 PolicyEngine/policyengine-us 的全部 Issue
相似的 Issue
-
难度 1/5 1 小时以内 新手友好度 86/100
benchflow-ai/skillsbench#1090 ·
-
Missing unit tests for human-readable date/time formatters in utils/datetime.py可能已有人在做 @prabhleen2317 今天认领。 未关闭
难度 2/5 1-3 小时 新手友好度 76/100
apache/iceberg-python#4387 ·
维护者通常 1 天内回复
-
[BUG] Hermes MCP adapter drops cwd, extra passthrough keys and the SSE transport when writing config.yaml可能已有人在做 @Parth-Vasave 今天认领。 未关闭
难度 2/5 1-3 小时 新手友好度 76/100
维护者通常 1 天内回复
-
backend bug
难度 2/5 1-3 小时 新手友好度 68/100
-
难度 2/5 1-3 小时 新手友好度 78/100
NVIDIA/numba-cuda-mlir#467 · 1 条评论 ·
维护者通常 3 天内回复