Move the deploy workflow's routing and sentinel steps into tested scripts

未关闭
#1,003 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 2 天内回复

已经有一个关联 PR 被合并了。

  • #1004 来自 @anth-volk —— 已合并

评估

难度
4/5
预计耗时
3-5 天
新手友好度
1/100
Issue 类型
重构
描述清晰度
描述清楚
活跃度
停滞
技术栈
github-actions, python
领域
ci-cd, testing

调研方向

Start with .github/workflows/simulation-deploy.reusable.yml and the seven named steps, then inspect rules/baselines/ci-multiline-run.txt and the tests that read shell from the workflow YAML. Move each block into a tested script under .github/scripts/, update the tests to run those scripts, and remove the seven baseline entries. Done when all seven steps keep identical behavior and their tests pass.

由索引模型根据 Issue 内容生成。

描述

Phase 1 step 1.7 of the rules work, follow-up to #763: the seven multi-line run: blocks that #743 and #744 added to .github/workflows/simulation-deploy.reusable.yml move into tested scripts under .github/scripts/, each called from a single-command step, with identical behaviour.

The seven steps:

  • update_routing: Plan the routing change, Record the unfinished routing publication, Publish the planned routing
  • sentinel_expected: Check the sentinel names this deployment's bundle
  • integration: Check the deployed stack reproduces the sentinel numbers
  • promote_entrypoint: Verify the stable service reproduces the sentinel numbers
  • finalize_routing: Finalize the routing publication

#763 left them in rules/baselines/ci-multiline-run.txt (rule sim.ci.multiline-run-is-script) because their tests read the steps' shell from the workflow YAML. Those tests are rewritten to run the scripts, and the seven baseline entries are removed. The six blocks in simulation-rollback.yml follow in a separate pull request.

主要语言
Python
星标
1
派生
1
平均合并
2 天 48 分钟
30 天内合并 PR
87

环境准备

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

PolicyEngine/policyengine-sim-api 的其他 Issue

查看 PolicyEngine/policyengine-sim-api 的全部 Issue

相似的 Issue

更多 Python Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。