Hacktoberfest 2026：维护者为十月标记出来的 issue，仍然开放、适合新手。 浏览 Hacktoberfest issue

A simulation built from a situation keeps the old system's defaults after apply_reform

未关闭
  • 哪里不对？
#614 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 2 天内回复

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
57/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
活跃
技术栈
python
领域
backend, backend-api-design

调研方向

Start with SimulationBuilder, Simulation.apply_reform, and _invalidate_all_caches, then read the changes in #613 to understand _build_from_situation and skip_rejected_inputs. Reproduce the examples in the issue with the stated Python command, including a set_input call after construction. Done when applying a reform rebuilds situation inputs under the new system while preserving inputs added afterward, and the three salary calculations match the expected values.

由索引模型根据 Issue 内容生成。

描述

Problem

A simulation built from a situation keeps, after its system changes, the inputs the situation builder made under the old system. SimulationBuilder gives the people a situation gives no value for a variable it gives others (or sets along axes) that variable's default and stores the whole array as an input, so those people keep the old system's default. #612 is the same leak into a reform simulation's baseline; this is the other direction, into the reformed simulation.

Reproduced on master b909d5a60 (and on #613's branch, which does not change it), from the repository root with uv run --frozen --extra dev python:

import sys; sys.path.insert(0, ".")
from policyengine_core.country_template import CountryTaxBenefitSystem, Simulation
from tests.core.test_reform_baseline_system import change_salary_default  # salary default 0 -> 1000

P = "2022-01"
sit = {"persons": {"a": {"salary": {P: 3000.0}}, "b": {}}, "households": {"h": {"parents": ["a", "b"]}}}
print(Simulation(situation=sit, reform=change_salary_default).calculate("salary", P))  # [3000. 1000.]

s = Simulation(situation=sit)
s.apply_reform(change_salary_default)
print(s.calculate("salary", P))  # [3000.    0.]: the reform's default is 1000

s2 = Simulation(tax_benefit_system=CountryTaxBenefitSystem(), situation=sit, reform=change_salary_default)
print(s2.calculate("salary", P))  # [3000.    0.]
  • apply_reform changes the system in place, and _invalidate_all_caches replays every recorded input, including the arrays the builder filled with the old default.
  • Simulation.__init__ with both tax_benefit_system and reform builds the situation under the system it was given, then applies the reform to that system (apply_reform_set).

policyengine-us applies its structural reforms with apply_reform right after Simulation.__init__, so a structural reform that changes an input variable's default (or neutralizes one the situation gives) reaches its household simulations this way.

Expected

After its system changes, a simulation built from a situation holds what the builder makes of that situation under the new system, plus any inputs set on it afterwards.

Notes

#613 adds Simulation._build_from_situation and SimulationBuilder.skip_rejected_inputs, which build a situation into a simulation under its own system. Rebuilding on apply_reform also needs to keep the inputs set after construction (set_input calls, which _invalidate_all_caches replays today) apart from the builder's.

主要语言
Python
星标
22
派生
30
平均合并
2 天 19 小时
30 天内合并 PR
25

环境准备

从这里开始

  1. 先读完整个 Issue，再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库，在一个分支上完成修改。
  4. 提交 Pull Request，并在描述里引用这个 Issue 编号。

PolicyEngine/policyengine-core 的其他 Issue

查看 PolicyEngine/policyengine-core 的全部 Issue

相似的 Issue

更多 Python Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。