ability_changelog_prose.csv inconsist compared to handling of other past_x variables.
还没有人认领这个 Issue。
评估
调研方向
首先定位 ability_changelog_prose.csv 以及 API 使用的相应历史 ability 数据;将各世代的 Sturdy 记录与 issue 中的 Gen 4 示例进行比较。更新英文历史描述,使每个世代都说明该 ability 的行为,然后验证 CSV 仍与 API 的 past_* 组织方式一致,并涵盖所引用的案例。
由索引模型根据 Issue 内容生成。
描述
For most things, like past learnsets, past_stats, or past_abilities, the api lists what those things were, and then what generation they changed.
Example would be Clefable, whose Special Attack went from 85 to 95 in Gen 6.
In the API, it looks like this:
pokemon_id, generation_id, stat_id, base_stat, effort36,5,4,85,0,
This means if I want to pull Clefables stats from Gen 5 or earlier, I have them.
Rather than doing that for abilities, the ability_changelog_prose.csv is presenting something closer to patch notes but backwards.
For example, sturdy changed in Gen 5 to be its current effect:
When this Pokémon is at full HP, any hit that would knock it out will instead leave it with 1 HP. Regardless of its current HP, it is also immune to the one-hit KO moves: fissure, guillotine, horn drill, and sheer cold. If this Pokémon is holding a focus sash, this ability takes precedence and the item will not be consumed.
I would expect this, if I pulled gen 4 data, to say:
The Pokemon is immune to the one-hit KO moves: fissure, guillotine, horn drill, and sheer cold.
What the changelog actually says is:
Does not prevent regular KOs from full HP.
Would we be open to the idea that the changelog_prose contains what the ability actually does in its past gens to be consistent with data is organized?
I would be willing to do the work for English.
- 主要语言
- Python
- 星标
- 5.4k
- 派生
- 1.2k
- 平均合并
- 2 天 12 小时
- 30 天内合并 PR
- 18
贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
PokeAPI/pokeapi 的其他 Issue
-
难度 2/5 1-2 天 新手友好度 76/100
-
bug
难度 1/5 1 小时以内 新手友好度 88/100
-
难度 3/5 1-2 天 新手友好度 55/100
-
难度 3/5 1-2 天 新手友好度 48/100
-
Ball legality 未关闭
难度 5/5 一周以上 新手友好度 35/100
相似的 Issue
-
agent-ready documentation needs-triage
难度 1/5 1-3 小时 新手友好度 88/100
-
documentation
难度 1/5 1 小时以内 新手友好度 91/100
-
workflow-status page template still says reusable workflows are "triggered only by workflow_call:" 未关闭
难度 1/5 1 小时以内 新手友好度 92/100
-
instance instance add
难度 1/5 1 小时以内 新手友好度 72/100
searxng/searx-instances#939 · 1 条评论 ·
-
area-deployment area-integrations triage:bot-seen
难度 2/5 半天 新手友好度 86/100