Feature Request: Tests filters in pipeline
还没有人认领这个 Issue。
评估
- 难度
- 5/5
- 预计耗时
- 一周以上
- 新手友好度
- 28/100
- Issue 类型
- 功能
- 描述清晰度
- 需要澄清
- 活跃度
- 停滞
- 领域
- testing
调研方向
先阅读 OpenTabletDriver.Plugin/Output/OutputMode.cs 第 62-90 行附近的内容，以了解 PipelinePosition 如何控制过滤器插入。先确定 0.6.x 的测试方案，然后覆盖未消费的 IDeviceReports 和无效的 PipelinePosition 值，同时不要显著扩大对 0.5.x API 的覆盖范围。
由索引模型根据 Issue 内容生成。
描述
The OpenTabletDriver 0.6.x plugin pipeline has edge cases that can cause filter plugins to incorrectly drop reports.
For plugins with filters targeting the 0.6.x plugin API the following tests should be done.
Plugins targeting earlier API's like 0.5.x should preferably not be covered if it significantly increases the amount of code to maintain.
It is unclear how to implement these tests properly. I currently have 2 ideas:
- Have a separate repository that can be targeted as a GitHub action, that tests the filter in a virtual pipeline, which could be used to test pull requests on this repository in some way.
- Driver gets a "Plugin Developer" mode that would actively check active filters for these issues - this would help plugin developers from making these mistakes unintentionally.
While outside of the scope of this issue, future driver plugin API's should preferably be designed in a way that removes these necessary tests.
Minimum Test Coverage
At the very minimum, the tests should check for the following
Properly passes through IDeviceReports
Some filters incorrectly only pass through ITabletReports. Normal filters should ensure Consume(IDeviceReport) runs Emit?.Invoke(). Async filters should ensure ConsumeState() runs OnEmit() (or Emit?.Invoke()) on unconsumed reports.
Sets a PipelinePosition that isn't PreTransform or PostTransform (or an alias)
Currently, the driver only links filters that have a PipelinePosition with one of the above values as seen here:
https://github.com/OpenTabletDriver/OpenTabletDriver/blob/aa345e5b7365647f25c8651f3e35fb7dd4c13676/OpenTabletDriver.Plugin/Output/OutputMode.cs#L62-L90
This means that a PipelinePosition of e.g. 0 would result in the filter never being inserted into the pipeline.
If you think of anything else that would be worth testing for, please let us know here.
- 主要语言
- Shell
- 星标
- 9
- 派生
- 39
- 平均合并
- 2 天 13 分钟
- 30 天内合并 PR
- 4
环境准备
这个项目没有提供开发容器、Dockerfile 或贡献指南，环境需要你自己搭建：先看它的 README，通用步骤见我们的新手贡献指南。
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
OpenTabletDriver/Plugin-Repository 的其他 Issue
-
enhancement
难度 3/5 1-2 天 新手友好度 35/100
OpenTabletDriver/Plugin-Repository#77 · 4 条评论 ·
查看 OpenTabletDriver/Plugin-Repository 的全部 Issue
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 72/100
gnosis/gnosis_vpn#540 ·
维护者通常 1 天内回复
-
good first issue needs-triage priority: medium
难度 2/5 1-3 小时 新手友好度 72/100
melodic-software/claude-code-plugins#6631 · 1 条评论 ·
维护者通常 1 天内回复
-
Lid close does not lock the session on Apple Silicon (lid-close bind skips omarchy-system-lid-close)未关闭
难度 1/5 1-3 小时 新手友好度 90/100
omacom/omarchy-mac#701 · 1 条评论 ·
维护者通常 1 天内回复
-
A 20.x release after 21.0.0 would move `latest` back to 20.x, and `next` stays on the release candidate可能已有人在做 @armando-navarro 今天认领。 未关闭comp: build/pipeline type: bug version: current (v17+)
难度 2/5 1-3 小时 新手友好度 85/100
angular/angularfire#3790 ·
维护者通常 3 天内回复
-
ready-for-agent
难度 2/5 1-3 小时 新手友好度 85/100
LucasSantana-Dev/Lucky#2698 ·
维护者通常 1 天内回复