cupsd crashes in _ppdCreateFromIPP2() when a printer reports a media size with no PPD name (e.g. jpn_chou2)

未关闭 适合新手
#1,828 4 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
2/5
预计耗时
1-3 小时
新手友好度
78/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
活跃
技术栈
c
领域
backend

调研方向

所有八处 NULL 使用都在 cups/ppd-cache.c 的 _ppdCreateFromIPP2() 中:两个 ppdname 默认值,以及 media-col-database、media-size-supported 和 media-supported 循环中的 copy/snprintf("%s.Borderless") 调用;再往下的 *PageSize 写入器已经用 && pwg->ppd 做了保护,因此把它作为范例。pwg_ppdize_name() 和有问题的 _PWG_MEDIA_MM("jpn_chou2_111.1x146mm", NULL, NULL, ...) 条目位于 cups/pwg-media.c。在设备外复现:将附带的 attr.txt 通过 ippReadIO() 和 _ppdCreateFromIPP() 传入;完成的标准是没有段错误,并且 PPD 列出全部 20 个尺寸,包括 Jpn_chou2_111.1x146mm。

由索引模型根据 Issue 内容生成。

描述

Disclaimer:
Found with Claude while debugging my printing software; I reproduced it and checked the analysis myself. Explanation below was written by Claude, too.

Describe the bug

cupsd segfaults while creating a temporary queue for a DNS-SD discovered driverless printer when one of the printer's media sizes maps to a pwg_media_t entry that has no PPD name. _ppdCreateFromIPP2() (cups/ppd-cache.c) copies pwg->ppd with strlcpy() / snprintf("%s") (cupsCopyString() on master) without checking it for NULL.

In our case the printer reports a 111×146 mm size (custom_111x146mm_111x146mm in media-supported, x-dimension 11100 / y-dimension 14600 in media-col-database and media-size-supported). pwgMediaForSize() matches that, within its tolerance, to jpn_chou2_111.1x146mm, which is defined in cups/pwg-media.c without a PPD name: _PWG_MEDIA_MM("jpn_chou2_111.1x146mm", NULL, NULL, 111.1, 146).

There are eight such uses in _ppdCreateFromIPP2(): the two ppdname defaults (media-col-default / media-default) and the copy / snprintf("%s.Borderless") in the media-col-database, media-size-supported and media-supported loops. The *PageSize writer further down in the same file already checks && pwg->ppd, so elsewhere the code already treats this field as possibly NULL.

The same code is still there in 2.4.20, on the current 2.4.x branch and on master.

To Reproduce

  1. On a Mac, share an HP Deskjet F2400 (USB) over the network. The shared queue reports the 111×146 mm size described above (full attributes attached as attr.txt).
  2. On a Linux machine in the same network running cupsd with Avahi, the printer shows up as a temporary queue in lpstat -l -e (network).
  3. Run lpoptions -p HP_Deskjet_F2400_series_Mac -l (or anything that calls cupsCopyDestInfo() on it). That sends CUPS-Create-Local-Printer, and cupsd builds a PPD from the printer's attributes.
  4. cupsd crashes with SIGSEGV. It is restarted, and the next query crashes it again.

Backtrace from the cupsd core dump (2.4.15, aarch64, cupsd without symbols):

#0  ?? () from libc.so.6
#1  strlcpy () from libc.so.6
#2  _ppdCreateFromIPP2 () from libcups.so.2
#3  ?? ()   (cupsd)

Same crash in an off-device repro: read the printer's Get-Printer-Attributes response with ippReadIO() and pass it to _ppdCreateFromIPP(). Against a 2.4.15 libcups with debug info:

#1  _cups_strlcpy (dst=..., src=0x0, size=...)
#3  _ppdCreateFromIPP2 (...) at ppd-cache.c:3721

Line 3721 is the strlcpy(temp.media, pwg->ppd, ...) in the media-col-database loop. The repro crashes on 2.4.15 and 2.4.20.

Expected behavior

cupsd creates the temporary queue. Sizes whose PWG entry has no PPD name get one made from the PWG name, or are skipped, instead of crashing.

A fix that works for us: fall back to a name built from the PWG name.

static const char *
pwg_ppd_name(pwg_media_t *pwg, char *buf, size_t bufsize)
{
  if (pwg->ppd)
    return (pwg->ppd);

  pwg_ppdize_name(pwg->pwg, buf, bufsize);
  return (buf);
}

Use pwg_ppd_name(pwg, ppdtemp, sizeof(ppdtemp)) in place of pwg->ppd at the eight places (ppdtemp being a local char[PPD_MAX_NAME]). With that, the PPD generated for the Deskjet has all 20 sizes including Jpn_chou2_111.1x146mm, and cupsd no longer crashes. A patch against 2.4.15 is available if useful.

System Information:

  • OS and its version: custom Yocto Linux (yocto-5.3.4 / whinlatter), Raspberry Pi 5, aarch64, glibc 2.42, systemd
  • Application: lpoptions (CUPS CLI); also our own client calling cupsCopyDestInfo()
  • CUPS version: 2.4.15 (crash also reproduced with 2.4.20)
  • Printer: HP Deskjet F2400, USB on a Mac and shared over the network (driverless temporary queue on the Linux side)
  • Built with the OpenEmbedded recipe, configure options: --enable-dbus --with-dbusdir=/etc/dbus-1 --enable-browsing --disable-gssapi --enable-debug --disable-relro --enable-libusb --with-system-groups=lpadmin,root,sys,wheel --with-cups-group=lp --with-domainsocket=/run/cups/cups.sock --with-dnssd=avahi --with-systemd=/usr/lib/systemd/system --with-tls=openssl

Additional context

  • Attached: attr.txt, the ipptool --ippserver output for the shared queue (see REPORTING_ISSUES.md). Hostname, location, UUID and the printer's serial number are replaced; all media attributes are unchanged.
  • I searched existing issues and PRs and didn't find this reported. #760 is related (PPD generation failing for a temporary queue) but is a different problem.
主要语言
C
星标
1.8k
派生
362
平均合并
19 小时 12 分钟
30 天内合并 PR
8

环境准备

  • 提供 Dockerfile 或 Docker Compose 文件
  • 没有 Pull Request 模板
  • 阅读贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

OpenPrinting/cups 的其他 Issue

查看 OpenPrinting/cups 的全部 Issue

相似的 Issue

更多 C Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。