RFC: Deprecate allow_training_without_logprobs option
还没有人认领这个 Issue。
评估
- 难度
- 5/5
- 预计耗时
- 一周以上
- 新手友好度
- 30/100
- Issue 类型
- 重构
- 描述清晰度
- 基本清楚
- 活跃度
- 停滞
- 技术栈
- python
调研方向
首先审阅提案和相关的 PR #527,然后在 Python 代码库中定位 allow_training_without_logprobs 选项的所有使用位置。确认是否有任何用户依赖该选项,以及是否接受移除该选项;完成的标准是维护者作出决定,随后彻底移除该选项及其替代训练路径。
由索引模型根据 Issue 内容生成。
描述
Summary
We're considering removing the allow_training_without_logprobs option from ART. This RFC is to gather community feedback before making this change.
Background
The allow_training_without_logprobs option allows training without requiring generation logprobs from the model. However, this approach has several drawbacks:
-
Importance sampling requires logprobs for stable training: In our experiments and in the wider RL community, having generation logprobs is essential for importance sampling, which is critical for stable training results. Training without them leads to less reliable outcomes.
-
Code complexity: Maintaining this alternative path adds complexity to the codebase and makes it harder to reason about the training flow.
-
Subtle bugs: The additional code path creates opportunities for subtle bugs. For example, in PR #527 we discovered tool-call tokenization issues that were partially enabled by this mode's complexity.
Proposal
Remove the allow_training_without_logprobs option entirely, simplifying the codebase and ensuring all users benefit from the more robust training path that uses logprobs.
Request for Feedback
Is anyone in the community actively using allow_training_without_logprobs with good results?
If you're using this option and it's working well for your use case, please let us know:
- What is your use case?
- Why do you need to train without logprobs?
- What results are you seeing?
If we don't hear from users who depend on this feature, we plan to remove it in an upcoming release.
Related: #527
- 主要语言
- Python
- 星标
- 10.8k
- 派生
- 989
- 平均合并
- 11 小时 53 分钟
- 30 天内合并 PR
- 97
贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
OpenPipe/ART 的其他 Issue
-
难度 2/5 1-3 小时 新手友好度 72/100
-
难度 5/5 一周以上 新手友好度 25/100
-
难度 5/5 一周以上 新手友好度 10/100
-
难度 5/5 一周以上 新手友好度 42/100
-
enhancement
难度 4/5 3-5 天 新手友好度 48/100
相似的 Issue
-
bug priority:low
难度 2/5 1-3 小时 新手友好度 76/100
CyberAgent/psd2svg#436 ·
-
area/install-update comp/cli comp/desktop P3 sweeper:risk-compatibility type/bug
难度 2/5 1-3 小时 新手友好度 86/100
NousResearch/hermes-agent#122386 · 1 条评论 ·
-
ai-generated
难度 2/5 1-3 小时 新手友好度 78/100
-
难度 2/5 1-3 小时 新手友好度 78/100
vllm-project/production-stack#1105 ·
-
难度 2/5 1-3 小时 新手友好度 88/100