[BUG] Server won't start (and channels won't deploy) on a Turkish JVM locale
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
- 难度
- 3/5
- 预计耗时
- 1-2 天
- 新手友好度
- 66/100
- Issue 类型
- 缺陷
- 描述清晰度
- 描述清楚
- 活跃度
- 活跃
- 技术栈
- java
调研方向
Start with JdbcDao.addMetaDataColumn, where StringUtils.lowerCase builds the query name, and with the MyBatis mapper files that hold the type aliases. Reproduce by running the server with -Duser.language=tr -Duser.country=TR and deploying a channel. Done means startup and channel deploy both succeed under the Turkish locale, using Locale.ROOT for case-insensitive lookups or explicit class names in the mappers.
由索引模型根据 Issue 内容生成。
描述
Spun off from #476. It all started with a test failing on my Italian machine. Out of curiosity I tried Turkish, the classic locale troublemaker, and things got worse: the server doesn't even start.
Describe the bug
Turkish has a dotted and a dotless i, so "I".toLowerCase() gives ı. OIE trips over this twice:
- Startup: MyBatis 3.1.1 lowercases type aliases with the default locale, so
"Integer"becomes"ınteger", nobody knows what that is, and startup loops. - Deploy: with (1) worked around, every channel deploy fails.
JdbcDao.addMetaDataColumnbuilds the query name withStringUtils.lowerCase, so it looks foraddMetaDataColumnStrıng, finds nothing, and Derby says "SQL text pointer is null".
Consistently reproducible.
To Reproduce
Run the server with -Duser.language=tr -Duser.country=TR, then deploy any channel.
Expected behavior
OIE works regardless of the system locale.
Environment
- OS: macOS
- Java: Zulu 17.0.17
- Version:
main@ a13e6afb6
Workaround(s)
Run the JVM with an English locale.
Notes
As offered in #476, happy to look into a fix if that works for you. Rough ideas:
- for (1), use
java.lang.Integerin the mappers (25 lines; MyBatis is fixed upstream since 3.2.0, but that's a big jump); - for (2), use
Locale.ROOTwhere casing is used for lookups; - add a
tr_TRsmoke scenario so it stays fixed. That covers the CI half of #476.
Open to other approaches, of course.
- 主要语言
- Java
- 星标
- 227
- 派生
- 81
- 平均合并
- 2 天 18 小时
- 30 天内合并 PR
- 12
环境准备
- 提供 Dockerfile 或 Docker Compose 文件
- 没有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
OpenIntegrationEngine/engine 的其他 Issue
-
Outdated GitHub workflow action versions可能已有人在做 关联的 PR 仍在进行中或已合并。 未关闭
难度 2/5 1-3 小时 新手友好度 68/100
OpenIntegrationEngine/engine#485 ·
维护者通常 1 天内回复
-
enhancement
难度 2/5 1-3 小时 新手友好度 62/100
OpenIntegrationEngine/engine#478 · 1 条评论 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 68/100
OpenIntegrationEngine/engine#355 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 68/100
OpenIntegrationEngine/engine#347 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 68/100
OpenIntegrationEngine/engine#313 ·
维护者通常 1 天内回复
查看 OpenIntegrationEngine/engine 的全部 Issue
相似的 Issue
-
dev/release: verify-release-candidate.sh runs 0 Java tests with Debian's Maven可能已有人在做 @kou 今天认领。 未关闭Type: bug
难度 2/5 1-3 小时 新手友好度 72/100
apache/arrow-adbc#4947 ·
维护者通常 1 天内回复
-
bug
难度 2/5 1-3 小时 新手友好度 72/100
lysine-dev/okhttp#9814 ·
维护者通常 1 天内回复
-
bug
难度 2/5 1-3 小时 新手友好度 72/100
维护者通常 1 天内回复
-
1.20.1-FORGE bug
难度 2/5 1-3 小时 新手友好度 68/100
MehVahdJukaar/WoodGood#1348 ·
-
documentation faq
难度 2/5 1-3 小时 新手友好度 72/100