[BUG] Configuration Map keys containing dots silently fail to expand in connector fields (Velocity property navigation
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
调研方向
Start at TemplateValueReplacer.getDefaultContext() and loadContextFromMap, which put the Configuration Map into the Velocity context as a flat map. Connector fields (e.g. Database Reader/Writer URL) are expanded with Velocity, so ${a.b.c} is property navigation, not a dotted key. Decide among docs, a UI warning on dotted keys, or a deploy-time log when ${...} is left unresolved; there is no linked PR and no comments yet.
由索引模型根据 Issue 内容生成。
描述
Describe the bug
A Configuration Map key that contains dots — for example db.warehouse.url — is not
expanded when referenced as ${db.warehouse.url} in a connector field such as a Database
Reader/Writer URL, username or password. The raw ${...} text is passed through to the
connector, which then fails with an error that points at the connector rather than at the
key name.
Keys with no dots expand correctly in the same fields.
Consistently reproducible: yes, on every deploy, on both Database Reader and Database
Writer, in url, username and password.
The underlying cause is that connector fields are resolved with Velocity, where ${a.b.c}
means "object a, property b, property c" rather than a lookup of a flat key named
a.b.c. The Configuration Map is loaded into the Velocity context as a flat map
(TemplateValueReplacer.getDefaultContext() calls
loadContextFromMap(context, ConfigurationController.getInstance().getConfigurationMap())),
so a dotted key exists in the map but is unreachable through dotted reference syntax.
Velocity leaves an unresolvable reference untouched, which is why the literal is passed on.
I am not arguing Velocity should behave differently. The problem is that this fails with
no warning anywhere, and the resulting error misdirects.
To Reproduce
- Settings -> Configuration Map, add a key with dots:
test.cfgmap.url = jdbc:postgresql://host.example.org:5432/db - Create a channel with a Database Reader source.
- Set the Reader's URL to
${test.cfgmap.url}, driverorg.postgresql.Driver,
select statementSELECT 1.
Steps to reproduce the behavior:
- Deploy the channel.
- Look at the server log.
- See the deploy fail with the unexpanded literal.
Expected behavior
${test.cfgmap.url} resolves to the Configuration Map value, the same way a key without
dots does — or, failing that, some indication that the reference could not be resolved.
Actual behavior
The literal ${test.cfgmap.url} is handed to the connector:
Caused by: com.mirth.connect.donkey.server.ConnectorTaskException: Failed to initialize database connection
at com.mirth.connect.connectors.jdbc.DatabaseReceiverQuery.initConnection(DatabaseReceiverQuery.java:124)
at com.mirth.connect.connectors.jdbc.DatabaseReceiverQuery.start(DatabaseReceiverQuery.java:87)
at com.mirth.connect.connectors.jdbc.DatabaseReceiver.onStart(DatabaseReceiver.java:115)
Caused by: java.sql.SQLException: No suitable driver found for ${test.cfgmap.url}
at java.sql/java.sql.DriverManager.getConnection(DriverManager.java:706)
at com.mirth.connect.connectors.jdbc.DatabaseReceiverQuery.initSelectConnection(DatabaseReceiverQuery.java:340)
With a dot-free key (stedi_mode, whose value is P) the same channel produces:
java.sql.SQLException: No suitable driver found for P
which is the expected substitution — P is not a valid JDBC URL, so it fails, but the
value was clearly resolved.
With dot-free keys used for url, username and password throughout, the Database Reader
connects successfully, emits a row, and the Database Writer connects and sends
successfully. So both connectors do expand these fields; only the dots break it.
There is no WARN or ERROR anywhere saying a reference was left unresolved.
Screenshots
N/A — log output above.
Environment (please complete the following information):
- OS: Windows Server 2025
- Java Distribution/Version: OpenJDK 17.0.19 (bundled with the OIE installer)
- Connect Version: Open Integration Engine 4.6.0
- Database backend: PostgreSQL 17
Behaviour should be platform-independent — Velocity's grammar and Java .properties key
handling are the same everywhere.
Workaround(s)
Yes, and it is easy once you know: do not use dots in Configuration Map keys that will be
referenced from connector fields. Rename db.warehouse.url to db_warehouse_url and
${db_warehouse_url} resolves correctly.
Note that dotted keys still work fine from JavaScript, because
configurationMap.get('db.warehouse.url') is a literal string lookup rather than a Velocity
template. So the same key works in one place and silently fails in another, which is what
makes this easy to trip over.
Additional context
Dots are a natural convention for namespacing configuration keys and the Configuration Map
UI accepts them without complaint, so this is easy to walk into. I suspect it is the origin
of the fairly widespread belief that Configuration Map values "don't work in connector
URLs" — they do, as long as the key has no dots.
Possible resolutions, cheapest first:
- Documentation — note that keys referenced from connector fields must not contain
dots, and that dotted keys remain usable from JavaScript viaconfigurationMap.get().
This alone would have saved me the investigation. - UI warning when a key containing a dot is added to the Configuration Map.
- Log a warning at deploy time when a connector field still contains an unresolved
${...}after replacement. This is the one I would find most valuable — it would
surface the whole class of unresolved-reference mistakes (typos, deleted keys, wrong
scope), not just dotted keys.
Happy to open a PR for the documentation change, or for option 3 if that is of interest.
- 主要语言
- Java
- 星标
- 227
- 派生
- 81
- 平均合并
- 3 天 6 小时
- 30 天内合并 PR
- 15
环境准备
- 提供 Dockerfile 或 Docker Compose 文件
- 没有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
OpenIntegrationEngine/engine 的其他 Issue
-
难度 2/5 1-3 小时 新手友好度 68/100
OpenIntegrationEngine/engine#485 ·
维护者通常 1 天内回复
-
enhancement
难度 2/5 1-3 小时 新手友好度 62/100
OpenIntegrationEngine/engine#478 · 1 条评论 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 68/100
OpenIntegrationEngine/engine#355 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 68/100
OpenIntegrationEngine/engine#347 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 68/100
OpenIntegrationEngine/engine#313 ·
维护者通常 1 天内回复
查看 OpenIntegrationEngine/engine 的全部 Issue
相似的 Issue
-
BC remittance upload: a claim MSP refused (S03) is saved with a blank status instead of refused (F)未关闭type: bug
难度 2/5 1-3 小时 新手友好度 88/100
carlos-emr/carlos#4933 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 68/100
Vakore/ZappierGames#147 ·
-
spigotmc
难度 1/5 1 小时以内 新手友好度 92/100
Dans-Plugins/Wild-Pets#356 ·
维护者通常 1 天内回复
-
spigotmc
难度 1/5 1 小时以内 新手友好度 85/100
Dans-Plugins/Medieval-Roleplay-Engine#371 ·
维护者通常 1 天内回复
-
bug
难度 2/5 1-3 小时 新手友好度 84/100
维护者通常 2 天内回复