To commit or not commit notebook output...
还没有人认领这个 Issue。
评估
- 难度
- 5/5
- 预计耗时
- 一周以上
- 新手友好度
- 25/100
- Issue 类型
- 功能
- 描述清晰度
- 需要澄清
- 活跃度
- 停滞
- 技术栈
- github-actions, jupyter-notebook
调研方向
首先比较 tutorials/rbfe_python_tutorial.html 文档使用的 notebook 与 ExampleNotebooks 中 .github/workflows/CI.yml 的 notebook 列表和执行步骤。查看 OpenFF 如何处理嵌入的 notebook 输出,然后定义并记录一个 workflow,使其完成后的输出在 repository 和渲染后的文档中保持一致。
由索引模型根据 Issue 内容生成。
描述
I do think that it is best practice to not keep the output BUT we need the output so that our docs render the output:
https://docs.openfree.energy/en/stable/tutorials/rbfe_python_tutorial.html
I think what we should do is maybe have CI do the rendering (it already does the running (at least on these notebooks https://github.com/OpenFreeEnergy/ExampleNotebooks/blob/main/.github/workflows/CI.yml#L68 we will want to make sure those are a 1-1 match of the notebooks we have in our docs))
We could have the result of running the notebooks committed on merge into main? That way it won't clutter up the PR (with each CI run you would need to pull changes) BUT I don't think that would actually help since the output would still be saved...
We could have RTD keep the output which would fix the issue of the docs not having the output BUT that means that if you clone the repo or view the repo with a web browser there still would be no output.
I am not really sure what we should do here, maybe see what OpenFF does? They have the same-ish setup for embedding notebooks in their docs.
This will probably be a bigger issue to work out BUT I think the typo fixes you have here are great 🎉 so could you include the output for now? I will turn this comment into an issue that we can use to discuss what we want to do RE: notebook output being committed.
Originally posted by @mikemhenry in https://github.com/OpenFreeEnergy/ExampleNotebooks/issues/163#issuecomment-2402982475
- 主要语言
- Jupyter Notebook
- 星标
- 70
- 派生
- 15
- 平均合并
- 10 小时 42 分钟
- 30 天内合并 PR
- 2
贡献指南
这个仓库没有索引到贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
OpenFreeEnergy/ExampleNotebooks 的其他 Issue
-
难度 3/5 1-2 天 新手友好度 68/100
-
难度 3/5 1-2 天 新手友好度 45/100
-
难度 5/5 一周以上 新手友好度 25/100
OpenFreeEnergy/ExampleNotebooks#279 · 1 条评论 ·
-
OpenFreeEnergy/ExampleNotebooks#277 · 1 条评论 · 已指派 1 人 ·
-
OpenFreeEnergy/ExampleNotebooks#241 · 1 个 reaction · 已指派 1 人 ·
查看 OpenFreeEnergy/ExampleNotebooks 的全部 Issue
相似的 Issue
-
status: needs triage
难度 2/5 1-3 小时 新手友好度 70/100
-
难度 2/5 1-3 小时 新手友好度 75/100
conda-forge/spacy-feedstock#177 ·
-
难度 2/5 1-3 小时 新手友好度 70/100
-
area:jail bug security severity:low track:open-source
难度 1/5 1 小时以内 新手友好度 75/100
-
难度 2/5 1-3 小时 新手友好度 65/100
micro-ROS/micro_ros_setup#837 ·