Redesign "Remember my choice" checkbox in WAYF

未关闭
#2,066 1 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 2 天内回复

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
58/100
Issue 类型
功能
描述清晰度
基本清楚
活跃度
冷清
技术栈
php

调研方向

定位 WAYF 屏幕的实现,以及对 wayf.remember_choice 和 wayf.remember_choice_per_idp 的现有处理。检查翻译后的标签和工具提示如何使用 wayf.remember_choice_per_idp_lifetime,包括小于一天的值,然后验证 per-SP 和全局布局。完成的标准是涵盖所要求的间距、顺序、样式、翻译、工具提示行为以及依赖设置的持续时间。

由索引模型根据 Issue 内容生成。

描述

discovery UI

To support the new "Remember my choice per SP" feature of #1956, we want ot make adjustment to the UI of the WAYF screen.

For reference the current layout when wayf.remember_choice is enabled:

Image

We would like to make small adjustments.

in the case that we use a per-sp "remember my choice" (both wayf.remember_choice and wayf.remember_choice_per_idp enabled):

Image

The following changes have been made:

  • Adjust the margins, switch the order of the checkbox and the text, adjust the text colour and weight, and add a tooltip ⓘ.

  • The mockup above uses this html (but tooltip hover doesn't work):

    <form method="post" action="https://engine.test2.surfconext.nl/authentication/idp/process-wayf" class="wayf__rememberChoice">
        <input type="checkbox" name="rememberChoice" id="rememberChoice">
        <label for="rememberChoice">Remember my choice for this service for 90 days</label>
        <label class="tooltip" for="rememberChoice" style="margin-left: .5em;alignment-baseline: ideographic;">
            <span class="visually-hidden">Tooltip text here</span>
        </label>
    </form>
    
  • Tooltip should show this text:

    • NL: "Als je deze optie aanzet, hoef je de komende 90 dagen voor deze dienst niet meer te kiezen hoe je wilt inloggen. Het inlogscherm wordt dan overgeslagen. Let op: gebruik je soms een ander account om in te loggen? Zet de optie dan uit. Je kunt de keuze later weer terugdraaien op profile.surfconext.nl."
    • EN: "If you enable this option, you won’t need to choose how you want to log into this service for the next 90 days. The login screen will then be skipped. Please note: do you sometimes use a different account to log in? If so, please disable this option. You can reverse this setting later at profile.surfconext.nl."
    • PT: "Se ativar esta opção, não terá de escolher como pretende iniciar sessão nos próximos 90 dias. O ecrã de início de sessão será então ignorado. Atenção: por vezes utiliza uma conta diferente para iniciar sessão? Nesse caso, desative esta opção. Pode reverter esta opção mais tarde em profile.surfconext.nl."
  • the "90 days" phrase should be based on what it set in the wayf.remember_choice_per_idp_lifetime application setting. There is no need to do full date parsing here. A simple check that converts to minutes if wayf.remember_choice_per_idp_lifetime<24h and to days otherwise is fine.

For a global "remember my choice" setting (i.e. wayf.remember_choice true and wayf.remember_choice_per_idp false), the WAYF should look similar, but with adjusted text and without tooltip:

Image
主要语言
PHP
星标
17
派生
26
平均合并
3 天 2 小时
30 天内合并 PR
3

环境准备

这个项目没有提供开发容器、Dockerfile 或贡献指南,环境需要你自己搭建:先看它的 README,通用步骤见我们的新手贡献指南。

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

OpenConext/OpenConext-engineblock 的其他 Issue

查看 OpenConext/OpenConext-engineblock 的全部 Issue

相似的 Issue

更多 PHP Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。