First-setup pairing window is too short and stays open after the first bond
维护者通常 1 天内回复
评估
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 新手友好度
- 55/100
- Issue 类型
- 功能
- 描述清晰度
- 基本清楚
- 活跃度
- 活跃
- 技术栈
- rust
调研方向
Start by reading contracts/opencar/core/v1/transport.toml, core_interface::close_pairing_window(), and docs/ble.md; then trace where the first bond is stored and check whether the app setup wizard displays the timeout. Confirm how buttonless boards use the pairing timer and what can trigger a second bond. Done when first setup has a longer finite window, the button window remains 60 seconds, the window closes after the first bond, and any affected wizard guidance and BLE documentation are updated.
由索引模型根据 Issue 内容生成。
描述
Problem
- After #18 (PR #46), a board without a pairing button opens the pairing window at boot only while no phone is bonded (first setup). It uses the shared
pairing_window_seconds(60 s) fromcontracts/opencar/core/v1/transport.toml, the same value as the button window. - 60 s is tight for first setup: the owner has to plug the device in, open the app and get through the wizard before it runs out. On a WiCAN, a retry means unplugging it from the OBD port.
- The window also doesn't close when a phone bonds:
core_interface::close_pairing_window()has no callers, so the window runs its full timer even after the owner has paired, and a second phone can bond during that time.
Ideas
- Give the first-setup window its own, longer duration (around 5 min). That needs a new key in
transport.toml(append-only), next topairing_window_seconds. Keep the button window at 60 s. - Close the window as soon as the first bond is stored on a buttonless board. A stranger who bonds first then makes the owner's pairing fail visibly, instead of both phones ending up bonded.
- Don't make the first-setup window unlimited: a device whose setup was abandoned would stay open to any phone in range for as long as it's powered (pairing is Just Works).
- Check whether the app's setup wizard shows the timeout, and update it if so.
- Update
docs/ble.md.
Done when
First setup on a buttonless board has enough time to finish comfortably, and the window closes once the first phone is bonded.
- 主要语言
- Rust
- 星标
- 1
- 派生
- 0
- 平均合并
- 11 小时 26 分钟
- 30 天内合并 PR
- 18
环境准备
在浏览器里用你自己的 GitHub 账号启动这个项目的开发容器。
- 没有 Dockerfile 或 Docker Compose 文件
- 没有 Pull Request 模板
- 没有贡献指南
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
OpenCarControls/firmware 的其他 Issue
-
难度 3/5 1-2 天 新手友好度 51/100
OpenCarControls/firmware#68 ·
维护者通常 1 天内回复
-
enhancement
难度 5/5 一周以上 新手友好度 35/100
OpenCarControls/firmware#55 ·
维护者通常 1 天内回复
-
enhancement
难度 5/5 一周以上 新手友好度 35/100
OpenCarControls/firmware#54 ·
维护者通常 1 天内回复
-
难度 5/5 一周以上 新手友好度 35/100
OpenCarControls/firmware#51 ·
维护者通常 1 天内回复
-
e-gmp
难度 3/5 1-2 天 新手友好度 55/100
OpenCarControls/firmware#43 ·
维护者通常 1 天内回复
查看 OpenCarControls/firmware 的全部 Issue
相似的 Issue
-
checkpoint/verify/rebuild_indexes on a thread holding a WriteTransaction deadlock instead of INT-001未关闭bug known-issue
难度 2/5 1-3 小时 新手友好度 74/100
project-minigraf/minigraf#734 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 70/100
-
难度 1/5 1 小时以内 新手友好度 88/100
维护者通常 4 天内回复
-
难度 2/5 1-3 小时 新手友好度 70/100
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 70/100
bitcoindevkit/electrum_streaming_client#57 ·
维护者通常 2 天内回复