`Value` has no coordinate-frame/transformation arm; posed geometry reads "unsupported"

未关闭
#2,343 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
5/5
预计耗时
一周以上
新手友好度
35/100
Issue 类型
功能
描述清晰度
基本清楚
活跃度
活跃
技术栈
go
领域
api, backend

调研方向

Start with api/proto/sysml.proto and internal/frontend/protoconv, then trace how ValCoordinateFrame and ValCoordinateTransformation are represented and how generated clients consume the Value union. The issue proposes new frame and transformation messages, but leaves their exact fields and wire shape open, so first settle those against the evaluator's available data. Done means the two values round-trip through the wire API, posed geometry no longer reports them as unsupported, and existing union arms still work.

由索引模型根据 Issue 内容生成。

描述

Disclaimer, this issue was detected and written by an AI

Summary

The engine evaluates coordinate frames and transformations
(instance_coordinate_frames), but the wire Value oneof has no arm for them.
internal/frontend/protoconv answers ValCoordinateFrame/
ValCoordinateTransformation with UnsupportedShown, so an inspector reports
{"kind":"null","reason":"unsupported: …"} for a posed element's placement/
coordinateFrame, and geometry views stay attributes-only.

Current state

  • api/proto/sysml.proto::Value.oneof kind ends at rational_value = 23; no
    frame/transform arm.
  • protoconv maps the engine's frame values to UnsupportedShown (the recorded
    ask's evidence).
  • The evaluator already computes them; only the wire representation is missing.

Proposal

Add two messages and oneof arms, shaped so every client can read them without
the engine's internal types:

  • CoordinateFrame { string id; string type; string owner; repeated string axes; … } — a frame reference by element id/qualified name plus the facts a placement
    needs.
  • CoordinateTransformation { Value/Owner source; Value/Owner target; repeated double matrix; … } — the transform between two frames.

Map ValCoordinateFrame/ValCoordinateTransformation to them in protoconv;
serialize them in every client's Value union (they are generated from the proto).
Keep UnsupportedShown for anything the service genuinely cannot represent.

Tests

  • A posed fixture: Evaluate/Instantiate answers a CoordinateFrame arm, not
    unsupported; a transformation answers its matrix and endpoints.
  • Round-trip: the client decodes the arm and prints a documented shape.
  • A non-frame value keeps its existing arm (no regression in the union).

Acceptance

  • placement/coordinateFrame are readable values, not unsupported.
  • The arm is documented in the wire contract; existing arms are unchanged.
主要语言
Go
星标
59
派生
20
平均合并
10 小时 23 分钟
30 天内合并 PR
897

环境准备

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

Open-MBEE/OpenSysML 的其他 Issue

查看 Open-MBEE/OpenSysML 的全部 Issue

相似的 Issue

更多 Go Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。