Improve BLS performance: cache parsed keys, add batch verification, add benchmarks

未关闭
  • 哪里不对？
#635 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

评估

难度
5/5
预计耗时
一周以上
新手友好度
35/100
Issue 类型
功能
描述清晰度
基本清楚
活跃度
冷清
技术栈
rust
领域
cryptography, distributed-systems, performance

调研方向

从 crates/crypto/src/blst_impl.rs 开始，沿着 crates/eth2util/src/signing.rs、dkg/src/aggregate.rs 和 cluster/src/lock.rs 中的验证路径进行追踪。使用 crates/k1util/benches 作为基准测试模板，并检查 crates/frost/src/curve.rs 中现有的包装器。完成的标准是：实现所提议的缓存、批量验证、安全聚合、scalar-hoisting 和 criterion 基准测试，并且能够对其进行测量。

由索引模型根据 Issue 内容生成。

描述

enhancement rust

Summary

All BLS operations take raw byte arrays (types.rs#L17-L21), so every call re-deserializes (verify does a G1 decompression per call) and re-runs subgroup checks — verify passes pk_validate = true and sig_groupcheck = true on every invocation. For a DV node the public shares are cluster-constant; nothing is memoized.

There is also no batch verification: blst's verify_multiple_aggregate_signatures is unused, and the hot paths verify one signature at a time — every incoming peer partial signature (parsigex → verify_eth2_signed_data → signing.rs#L148), a nested validators×partials loop in dkg/src/aggregate.rs#L146, and one builder registration per validator in cluster/src/lock.rs#L427.

Additionally, aggregate_public_keys hand-rolls point addition through unsafe FFI and skips per-key subgroup validation — blst's safe AggregatePublicKey::aggregate(..., validate) covers it. A second independent blst wrapper with safe constructors already exists in pluto-frost (crates/frost/src/curve.rs); the ad-hoc scalar helpers in blst_impl.rs duplicate it.

There are no benchmarks: the only criterion setup in the workspace is crates/k1util/benches, while Charon benchmarks its BLS backend (tbls_test.go BenchmarkHerumiImplementation).

Proposed change

  • Introduce parsed key/signature types (wrapping blst types) validated once at construction; keep raw bytes only at serialization boundaries.
  • Add a batch-verification entry point and use it on the partial-signature paths.
  • Replace the unsafe aggregation with the blst safe API; consolidate scalar helpers with pluto-frost's wrappers.
  • Hoist the O(n²) scalar_from_u64 recomputation out of the interpolation loops — evaluate_polynomial rebuilds the same scalar every iteration and compute_lagrange_coefficients reconstructs per-index scalars inside the inner loop; build them once per index.
  • Add criterion benches (sign/verify/aggregate/threshold_aggregate) using the k1util bench as a template, so wins are measurable.
主要语言
Rust
星标
8
派生
5
30 天内没有已合并 PR

环境准备

从这里开始

  1. 先读完整个 Issue，再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库，在一个分支上完成修改。
  4. 提交 Pull Request，并在描述里引用这个 Issue 编号。

NethermindEth/pluto 的其他 Issue

查看 NethermindEth/pluto 的全部 Issue

相似的 Issue

更多 Rust Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。