fix(ecs): reading a component grows the SparseArray, so a bad id can exhaust WASM memory
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 新手友好度
- 55/100
- Issue 类型
- 缺陷
- 描述清晰度
- 描述清楚
- 活跃度
- 活跃
- 技术栈
- cpp, typescript, wasm
调研方向
Start with the cited SparseArray.hpp operator[] and the Registry.hpp getEntityComponent and add_component entry points. Trace how reads handle out-of-range ids and how component registration and entity liveness are checked. Reproduce the large-id and SIZE_MAX cases, then run the relevant ECS/WASM tests; done means reads cannot grow the array and invalid entity ids are rejected safely.
由索引模型根据 Issue 内容生成。
描述
Which package is this bug report for?
ecs
Issue description
getEntityComponent and the embind get(idx) use the non-const operator[], which resizes on read: one stale or garbage id (e.g. 1e9) aborts the WASM heap. add_component accepts ids that were never spawned, and reads register component types as a side effect. On wasm32, idx == SIZE_MAX makes idx + 1 overflow to 0.
Where:
modules/ecs/wasm/SparseArray.hpp:159-165modules/ecs/wasm/Registry.hpp:111-118modules/ecs/wasm/Registry.hpp:198-205
Evidence:
reference_type operator[](size_type idx)
{
if (idx >= _data.size()) { _data.resize(idx + 1); }
return _data[idx];
}
Suggested fix: Use a read path that does not grow the array (return empty when out of range), and bounds-check add_component against _next_entity and the alive state.
Found during a code audit of main at be72076.
Code sample
No response
Versions
- Engine
mainat be72076 - pnpm 12.0.0, Node.js 26, Bun 1.3.14
Issue priority
Medium (should be fixed soon)
I have tested this issue on a development release
be72076
- 主要语言
- TypeScript
- 星标
- 7
- 派生
- 2
- 平均合并
- 1 天 17 小时
- 30 天内合并 PR
- 17
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
NanoForge-dev/Engine 的其他 Issue
-
dependencies enhancement good first issue
难度 2/5 1-3 小时 新手友好度 78/100
NanoForge-dev/Engine#513 ·
维护者通常 1 天内回复
-
bug chore tests
难度 2/5 1-3 小时 新手友好度 77/100
NanoForge-dev/Engine#511 ·
维护者通常 1 天内回复
-
docs(network): TSDoc says ICE_SERVERS defaults to an empty list, the code uses public STUN servers未关闭documentation good first issue modules:network
难度 1/5 1 小时以内 新手友好度 88/100
NanoForge-dev/Engine#509 ·
维护者通常 1 天内回复
-
documentation modules:ecs packages:asset packages:core
难度 2/5 1-3 小时 新手友好度 82/100
NanoForge-dev/Engine#508 ·
维护者通常 1 天内回复
-
bug good first issue modules:music modules:sound
难度 2/5 1-3 小时 新手友好度 78/100
NanoForge-dev/Engine#505 ·
维护者通常 1 天内回复
查看 NanoForge-dev/Engine 的全部 Issue
相似的 Issue
-
Mend: dependency security vulnerability
难度 1/5 1-3 小时 新手友好度 65/100
fdm-monster/fdm-monster#5563 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 72/100
be-BOP-io-SA/be-BOP#2849 ·
-
难度 2/5 1-3 小时 新手友好度 79/100
维护者通常 1 天内回复
-
1️⃣ phase/under-investigation flaky/confirmed flaky/needs-decision type/bug
难度 2/5 1-3 小时 新手友好度 65/100
growilabs/growi#12246 · 3 条评论 ·
维护者通常 1 天内回复
-
🐛 The Rulekeeper - An index run that gives up on the lock ends Succeeded可能已有人在做 @github-actions 今天认领。 未关闭
难度 2/5 1-3 小时 新手友好度 72/100
SSWConsulting/SSW.Rules#2809 · 1 条评论 ·
维护者通常 1 天内回复