Hacktoberfest 2026：维护者为十月标记出来的 issue，仍然开放、适合新手。 浏览 Hacktoberfest issue

`stop-when`: the fused token's callback can run twice, or be skipped, when the first token is already stopped

已关闭
  • 哪里不对？
#2,326 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

@workingBanana 已经在做这个了。

开始于 2026年10月12日。

  • #2327 来自 @workingBanana —— 未关闭

评估

难度
3/5
预计耗时
1-2 天
新手友好度
35/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
停滞
技术栈
cpp
领域
backend-api-design

调研方向

The issue identifies __stop_when_::__fused_token<T1, T2>::callback_type and gives a reproducer using stdexec/execution.hpp. Read the callback member declarations and constructor initialization order, then run the reproducer to check immediate invocation when the first token is already stopped. Done means the callback runs once at registration and is not called again when the second token stops. Pull request #2327 is already open against this issue.

由索引模型根据 Issue 内容生成。

描述

Summary

__stop_when_::__fused_token<T1, T2>::callback_type declares its once-flag __called_ after the two inner callbacks:

_Fn                 __fn_;
__cb1_t             __cb1_;
__cb2_t             __cb2_;
__std::atomic<bool> __called_{false};   // initialized last

If the first token is already stopped, __cb1_'s constructor invokes the callback immediately. That callback does __called_.exchange(true) on an object whose lifetime hasn't started yet. Then __called_'s initializer stores false. So the result depends on the indeterminate value:

  • if it was 0: the function runs at registration, the flag is reset, and the function runs a second time when the second token is stopped;
  • if it was non-zero: the function is skipped at registration. It runs only if the second token is stopped later, and is lost otherwise.

Both violate [exec.stop.when]: the callback must be invoked when either token is stopped, and at most once.

Introduced in https://github.com/NVIDIA/stdexec/pull/2234

Reproducer

#include <stdexec/execution.hpp>
#include <cstdio>

namespace ex = STDEXEC;

int main() {
  ex::inplace_stop_source a, b;
  a.request_stop(); // the sender's token is already stopped
  int calls = 0, at_registration = -1;
  auto probe = ex::read_env(ex::get_stop_token) | ex::then([&](auto token) {
    auto fn = [&]() noexcept { ++calls; };
    ex::stop_callback_for_t<decltype(token), decltype(fn)> cb(token, fn); // must run: a is stopped
    at_registration = calls;
    b.request_stop(); // must not run again
  });
  // The inner stop-when sees a stoppable receiver token (b), so its child gets a fused token.
  ex::sync_wait(ex::__stop_when(ex::__stop_when(probe, a.get_token()), b.get_token()));
  std::printf("calls at registration: %d (expected 1), in total: %d (expected 1)\n",
              at_registration, calls);
  return at_registration == 1 && calls == 1 ? 0 : 1;
}

Then output will be: calls at registration: 1 (expected 1), in total: 2 (expected 1). It should be 1 and 1.

主要语言
C++
星标
2.5k
派生
276
平均合并
1 天 13 小时
30 天内合并 PR
62

环境准备

这个项目没有提供开发容器、Dockerfile 或贡献指南，环境需要你自己搭建：先看它的 README，通用步骤见我们的新手贡献指南。

从这里开始

  1. 先读完整个 Issue，再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库，在一个分支上完成修改。
  4. 提交 Pull Request，并在描述里引用这个 Issue 编号。

NVIDIA/stdexec 的其他 Issue

查看 NVIDIA/stdexec 的全部 Issue

相似的 Issue

更多 C++ Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。