Remote log callback delivers no lines on the component-split branch (#1622)

未关闭
#1,878 2 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
52/100
Issue 类型
缺陷
描述清晰度
基本清楚
活跃度
活跃
技术栈
cmake, cpp, grpc

调研方向

运行 ./build.sh libcuopt,然后使用 CpuOnlyWithServerTest.log_callback_remote 过滤器执行 cpp/build/tests/linear_programming/C_API_TEST,先检查端口 18500。跟踪 cuopt_mathopt 和 cuopt_grpc 中的 callback 注册,包括 #1778 中按组件划分的 logger 实例。远程 solve 仍然成功且流式传输的日志行能够到达 callback,即表示完成。

由索引模型根据 Issue 内容生成。

描述

Description

On #1622 (feat/split-routing-lp-libs), CpuOnlyWithServerTest.log_callback_remote fails:

Expected remote solve to deliver log lines; got 0 calls
cpp/tests/linear_programming/c_api_tests/c_api_tests.cpp:797: Failure

The remote solve itself succeeds — CpuOnlyWithServerTest.lp_solve and .mip_solve pass, returning Optimal with the correct objective. Only the streamed log lines never reach the callback registered through cuOptSetLogCallback.

Not caused by the cuopt_base removal

I hit this while removing cuopt_base from that branch and checked before attributing it. Rebuilding the branch with cuopt_base restored (cpp/CMakeLists.txt and cpp/src/CMakeLists.txt from the pre-removal commit) reproduces the failure identically, so it predates that change.

It is specific to the component split: the same test passes on split/4-cuopt-client-library, which carries a monolithic libcuopt.so and is otherwise up to date with main.

Where to look

cuopt_mathopt no longer hard-links gRPC on that branch. It holds nullable callback slots that libcuopt_grpc.so's ELF constructor fills via register_remote_solvers(), and the log callback has to cross the same boundary. Two candidates:

  • the log callback is registered on one side of that boundary and read on the other, so the streaming path sees a null or default-constructed callback
  • per-component loggers (#1778) mean the log lines the gRPC client streams are written to a different logger instance than the one the C API callback is attached to

The second is worth checking first, since #1778 gave each component library its own logger and the remote log path spans cuopt_mathopt and cuopt_grpc.

Reproduce

./build.sh libcuopt
cd cpp/build
./tests/linear_programming/C_API_TEST --gtest_filter='CpuOnlyWithServerTest.log_callback_remote'

Note that the fixture forks a cuopt_grpc_server on port 18500. A leaked server from an earlier run will make lp_solve and mip_solve fail too, with Error solving problem: 6, which is a separate and purely local artifact — check ss -ltnp | grep 18500 before drawing conclusions.

Related: #1622, #1778, #1510.

主要语言
Cuda
星标
1.1k
派生
255
平均合并
1 天 11 小时
30 天内合并 PR
123

环境准备

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

NVIDIA/cuopt 的其他 Issue

查看 NVIDIA/cuopt 的全部 Issue

相似的 Issue

更多 Backend & API Design Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。