Rotate FK-tables instead of EKOs

未关闭
#183 15 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

@Radonirinaunimi 已经在做这个了。

开始于 2025年6月22日。

  • #227 来自 @Radonirinaunimi —— 未关闭

评估

难度
4/5
预计耗时
3-5 天
新手友好度
20/100
Issue 类型
功能
描述清晰度
描述清楚
活跃度
停滞
技术栈
python
领域
data

调研方向

Read src/pineko/evolve.py around the linked lines 282–286 and 313–320, then inspect the PineAPPL grid rotation change linked in the issue. The issue proposes evolving unrotated EKOs and rotating the resulting FK-tables; check the existing evolution tests and add coverage for that flow. The linked pull request #227 is open, so review its status before starting.

由索引模型根据 Issue 内容生成。

描述

good first issue refactor

There's another big optimization potential to speed up the generation of FK-tables. Currently, I believe, pineko works the following way (correct me if I'm wrong):

  1. we store flavour-basis to flavour-basis EKOs for all Q2 slices, but always for the standard 50 x-node points. The biggest EKO that we have, ATLAS_1JET_8TEV_R06, is 2.4 GB.
  2. Next, we reinterpolate the EKO to match the x-grid points actually used in the grid. For ATLAS_1JET_8TEV_R06 this blows up the size of the EKO to 22 GB.
  3. Finally, we rotate the EKO, such that the resulting FK-tables are in the evolution basis. This further increases the size, resulting in whopping 45 GB.

But thanks to some developments on PineAPPL's side, we can now perform a rotation at the level of grids (and therefore also FK-tables). So I suggest that

  • we perform the evolution using the unrotated EKOs, which has the advantage that the EKOs are much smaller, and finally
  • rotate the evolved FK-tables from the flavour-basis to the evolution basis.

The evolution in the flavour basis is much faster, it's roughly the quotient of the size of the EKOs. For ATLAS_1JET_8TEV_R06 it's roughly twice as fast (45 GB / 22 GB). With the added benefit that we need less disk space, of course.

Practically speaking, the changes on pineko's side should be minimal. We probably have to delete the following lines:
https://github.com/NNPDF/pineko/blob/9f8b03ce9132c91866a160e4396998abaca843c2/src/pineko/evolve.py#L282-L286
and instead add the rotation after the evolution:
https://github.com/NNPDF/pineko/blob/9f8b03ce9132c91866a160e4396998abaca843c2/src/pineko/evolve.py#L313-L320

主要语言
Python
星标
2
派生
0
平均合并
10 天 34 分钟
30 天内合并 PR
3

环境准备

  • 没有 Dockerfile 或 Docker Compose 文件
  • 没有 Pull Request 模板
  • 阅读贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

NNPDF/pineko 的其他 Issue

查看 NNPDF/pineko 的全部 Issue

相似的 Issue

更多 Python Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。