assignReward decrements MaintenancePool.balance before poolWithdraw() and never restores it when the withdrawal fails

未关闭
  • 哪里不对？
#459 5 条评论 0 个 reaction 已指派 1 人 在 GitHub 查看

维护者通常 1 天内回复

@Fabulouz34 已经在做这个了。

开始于 2026年9月29日。

  • #471 来自 @Proxima84-code —— 未关闭
  • #475 来自 @Fabulouz34 —— 未关闭

评估

这个 Issue 还没有评估数据。

描述

architecture bug Stellar Wave very hard

Problem

In MaintenancePoolService.assignReward(), the #274 atomic check-and-decrement runs before the on-chain payout:

const updateResult = await this.poolRepo
  .createQueryBuilder()
  .update(MaintenancePool)
  .set({ balance: () => `balance - :amount` })
  .where('id = :id AND balance >= :amount', { id, amount: Number(amount) })
  ...
  .execute();
if (updateResult.affected === 0) throw new BadRequestException(...);

const payment = await this.escrowService.poolWithdraw(pool.escrowId, amount, recipientAddress, recipientId);
return payment;

poolWithdraw() has several ways to throw after the balance has already been reduced:

  • assertLocked(escrow)
  • assertValidAmount(amount)
  • assertRecipientsMatchUsers(...): a recipientAddress that doesn't match recipientId's wallet
  • a Soroban simulate, send or poll failure inside invokeOnLockedEscrow
  • the final paymentRepo.save

None of these paths gives the reserved amount back, so every failed reward permanently shrinks the pool's DB balance, even though no USDC left the contract. Over time MaintenancePool.balance drifts below the real on-chain balance. Rewards then start failing with "exceeds pool balance" while funds are still in escrow, and there's no admin path to reconcile.

Suggested fix

  • Wrap the payout in try/catch. On failure, restore the reservation with increment({ id }, 'balance', Number(amount)) and rethrow.
  • Only do that when the on-chain call is known not to have gone through. invokeOnLockedEscrow's state distinguishes "never submitted" from "submitted, outcome unknown".
  • Move the cheap validation (recipient/user match, amount) before the decrement so bad input never touches the balance.
  • Add tests with poolWithdraw rejecting that assert the pool balance is unchanged.

Related: #51, #274 (introduced the reserve-first ordering), #163.

主要语言
TypeScript
星标
2
派生
90
平均合并
31 分钟
30 天内合并 PR
20

环境准备

  • 提供 Dockerfile 或 Docker Compose 文件
  • 没有 Pull Request 模板
  • 没有贡献指南

从这里开始

  1. 先读完整个 Issue，再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库，在一个分支上完成修改。
  4. 提交 Pull Request，并在描述里引用这个 Issue 编号。

MergeFi/backend 的其他 Issue

查看 MergeFi/backend 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。