Add top-level config ref
还没有人认领这个 Issue。
评估
- 难度
- 5/5
- 预计耗时
- 一周以上
- 新手友好度
- 25/100
- Issue 类型
- 功能
- 描述清晰度
- 需要澄清
- 活跃度
- 停滞
- 技术栈
- typescript
- 领域
- tooling
调研方向
Issue 中没有指定文件、测试或入口点。首先检查现有 schema 和 config 解析行为,然后明确顶层 $ref 继承、属性覆盖以及 Pick/Omit 应如何交互。完成的标准是:已指定受支持的语义和边界情况,并通过测试覆盖。
由索引模型根据 Issue 内容生成。
描述
Is your feature request related to a problem? Please describe.
We at Vector team deploy the same service with 99% the same config for different projects (e.g. Metatile-Queue-Populator/ Retiler). The only difference might be the queue which I'm subscribing to or DB name/ S3 Bucket/ directory in a S3 bucket. Currently, I'll have to create config-per-instance and maintain each one of them (which will result in duplicate config - in the current state of schema and service).
I also expect that I would be able to override properties from the shared config.
Describe the solution you'd like
I would like to be able to top-level $ref a "shared" config in the specific project config's and inherit it's config and override the properties which are project-specific.
Describe alternatives you've considered
Change the schema (again).
Additional context
This will enable us to create ts-server-boilerplate shared config and many more copy-paste config
An example
// shared schema
{
"foo": {
"type": "string"
},
"bar": {
"type": "string"
}
}
// shared config
{
"foo": "avi1",
"bar": "avi2"
}
// "full" schema
{
"$ref": "#/ref/to/shared/schema",
"baz": {
"type": "string"
}
}
// => which results to
{
"foo": {
"type": "string"
},
"bar": {
"type": "string"
},
"baz": {
"type": "string"
}
}
// "full" config
{
"$ref": "#/ref/to/shared/config",
"baz": "avi3"
}
// => which results to
{
"foo": "avi1",
"bar": "avi2",
"baz": "avi3"
}
//another valid edge-case option
{
"$ref": "#/ref/to/shared/config",
"foo": "avi420"
"baz": "avi3"
}
// => which results to
{
"foo": "avi420",
"bar": "avi2",
"baz": "avi3"
}
Points to consider:
I think we should also have Pick-Omit $ref support in order to, as you probably already guessed, pick a config value/ omit one.
- 主要语言
- TypeScript
- 星标
- 0
- 派生
- 0
- PR 合并指标
- 30 天内没有已合并 PR
环境准备
我们还没有检查这个项目的环境配置文件。先看它的 README,通用步骤见我们的新手贡献指南。
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
MapColonies/config-server 的其他 Issue
-
healthchek mechanism based on DB connection可能重新可做 @netanelC 于 617 天前认领,目前没有进行中的 PR。 未关闭bug
MapColonies/config-server#71 · 已指派 1 人 ·
-
难度 5/5 一周以上 新手友好度 30/100
MapColonies/config-server#61 ·
-
bug
难度 2/5 1-3 小时 新手友好度 48/100
MapColonies/config-server#55 ·
-
bug
难度 4/5 3-5 天 新手友好度 35/100
MapColonies/config-server#53 ·
-
bug
难度 2/5 1-3 小时 新手友好度 45/100
MapColonies/config-server#52 ·
查看 MapColonies/config-server 的全部 Issue
相似的 Issue
-
triage
难度 1/5 1 小时以内 新手友好度 90/100
维护者通常 1 天内回复
-
bug
难度 2/5 1-3 小时 新手友好度 68/100
mermaid-js/mermaid-live-editor#2053 ·
维护者通常 1 天内回复
-
factory
难度 2/5 1-3 小时 新手友好度 82/100
jessepollak/home#1455 ·
维护者通常 1 天内回复
-
community first-timers-only good first issue hacktoberfest help wanted low hanging fruit up-for-grabs
难度 1/5 1 小时以内 新手友好度 95/100
lingdojo/kana-dojo#31227 · 1 条评论 · 5 个 reaction ·
维护者通常 1 天内回复
-
难度 1/5 1 小时以内 新手友好度 92/100
appandflow/stim#1838 ·
维护者通常 1 天内回复