Enable Vue attribute formatting rules without changing rendered behavior
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
- 难度
- 3/5
- 预计耗时
- 半天
- 新手友好度
- 70/100
- Issue 类型
- 重构
- 描述清晰度
- 基本清楚
- 活跃度
- 活跃
- 技术栈
- javascript
调研方向
Start in eslint.config.mjs under the libresign/disabled-during-migration block and remove only the 'off' entries for vue/first-attribute-linebreak and vue/max-attributes-per-line. Run the dry-run layout preview on src/**/*.vue and check that the proposed edits only split or join attribute lines. Done when both rules are enabled, the diff changes only attribute layout, and npm run lint, npm run ts:check and npm run build pass.
由索引模型根据 Issue 内容生成。
描述
Goal
Enable two Vue template attribute-layout ESLint rules without changing HTML content, component behavior or visible UI. The work is layout-only and uses the existing ESLint preset and autofix workflow.
Rules
vue/first-attribute-linebreak(historical estimate: ~435 hits)vue/max-attributes-per-line(historical estimate: ~68 hits)
Counts are historical and may overlap; measure the current main before starting.
Good first issue
Start at eslint.config.mjs, inside libresign/disabled-during-migration, and at existing .vue templates under src/. This is similar to the merged formatting contribution in #9145. You do not need to design a Vue component, change business logic or modify APIs. Check ongoing work and discuss a genuine ambiguity with maintainers; no advance permission or assignment is required.
Step-by-step implementation
-
Create a branch based on the latest
mainand confirm a clean working tree. -
Verify the effective Nextcloud preset options for both rules. Remove only their
'off'entries fromeslint.config.mjsand leave their preset severity unchanged. -
Preview layout-only fixes without changing files:
npx eslint 'src/**/*.vue' --fix-dry-run --fix-type layout \ --format json > /tmp/eslint-vue-preview.json -
Record the current warning/error count and files affected. If the preview is limited to attribute line breaks and formatting, apply:
npx eslint 'src/**/*.vue' --fix --fix-type layout -
Review
git diff -- src/ eslint.config.mjs. Confirm changes only split/join attribute lines or adjust harmless layout. Verify every attribute name and value, Vue directive, binding expression,aria-*value, slot, event, selector and visible text is unchanged. Revert unrelated fixes produced by other already-enabled rules. -
Keep rule-specific commits separately reviewable with valid DCO sign-off. If a fix for one rule overlaps the other, explain the overlap rather than manufacturing meaningless edits.
-
Open one focused PR linking this issue. Report the changed-file count, before/after ESLint diagnostics and executed checks.
Verification
git diff --check
npm run lint
npm run ts:check
npm run build
Run npm test or the focused Vitest tests for any modified component whose rendering behavior needs verification. If a change unexpectedly affects rendered markup, include a sanitized screenshot or short video and request review before claiming success. A screenshot alone does not replace automated tests.
Done when
- Both layout rules inherit the intended Nextcloud preset options and applicable violations are resolved.
- Only attribute layout changes; props, slots, events, directives, CSS classes, accessible labels and user-visible text remain identical.
- The PR includes a reviewed diff, current diagnostics, file count, appropriate passing checks and signed-off commits.
- No generated code, translations, tests' assertions, new dependencies or unneeded suppressions are introduced.
Out of scope
Do not enable vue/attribute-hyphenation, event/slot casing rules, component-renaming rules, or introduce unrelated template refactors.
Additional context
Development workflow: https://docs.libresign.coop/developer_manual/development-workflow.html
Questions and community support: https://t.me/LibreSign
- 主要语言
- PHP
- 星标
- 844
- 派生
- 176
- 平均合并
- 14 小时 3 分钟
- 30 天内合并 PR
- 344
环境准备
在浏览器里用你自己的 GitHub 账号启动这个项目的开发容器。
- 没有 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
LibreSign/libresign 的其他 Issue
-
难度 2/5 1-3 小时 新手友好度 78/100
维护者通常 1 天内回复
-
OpenSSL engine: leaf certificates get O=Internet Widgits Pty Ltd, ST=Some-State from system openssl.cnf可能已有人在做 @vitormattos 于 5 天前认领。 未关闭
难度 2/5 1-3 小时 新手友好度 78/100
LibreSign/libresign#9366 · 已指派 1 人 ·
维护者通常 1 天内回复
-
难度 1/5 1 小时以内 新手友好度 83/100
LibreSign/libresign#9007 · 2 条评论 · 1 个 reaction ·
维护者通常 1 天内回复
-
good first issue
难度 2/5 1-3 小时 新手友好度 78/100
LibreSign/libresign#8284 · 5 条评论 ·
维护者通常 1 天内回复
-
frontend javascript technical debt
难度 5/5 一周以上 新手友好度 8/100
维护者通常 1 天内回复
查看 LibreSign/libresign 的全部 Issue
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 79/100
Automattic/blocks-engine#6318 ·
维护者通常 1 天内回复
-
kind/enhancement
难度 2/5 1-3 小时 新手友好度 76/100
维护者通常 1 天内回复
-
[remove-resource] Delete Open Course Hub, Open Multicourse Hub, and Learn2 with GitSync skeletons未关闭
难度 2/5 1-3 小时 新手友好度 68/100
-
难度 1/5 1 小时以内 新手友好度 88/100
-
难度 1/5 1 小时以内 新手友好度 82/100