Native crash (SIGSEGV in getSuggestionsNative) when typing with a multilingual secondary language

未关闭
  • 哪里不对？
#759 1 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
25/100
Issue 类型
缺陷
描述清晰度
基本清楚
活跃度
活跃
技术栈
android, cpp, kotlin
领域
mobile

调研方向

Start with DictionaryFacilitatorImpl.getSuggestionResults(), where secondary-dictionary queries run in scope.launch and are awaited for 120 ms, then BinaryDictionary.getSuggestions(), where only getTraverseSession() is synchronized and the native call is not. The work is to confirm that overlapping queries share one DicTraverseSession and then make access to that session safe; the reporter already has a candidate fix. Done means no SIGSEGV under overlapping queries, which needs a device or a concurrency reproduction.

由索引模型根据 Issue 内容生成。

描述

Describe the bug
With a secondary language added via Multilingual typing (German + English (US), both main dictionaries installed), the keyboard process sometimes crashes in native code (SIGSEGV, null pointer dereference in libjni_latinime.so). For us it happened right after tapping the clipboard suggestion and when typing fast.

Backtrace (shortened):

F libc    : Fatal signal 11 (SIGSEGV), code 1 (SEGV_MAPERR), fault addr 0x11 in tid 10828 (DefaultDispatch)
F DEBUG   : Cause: null pointer dereference
F DEBUG   :   #00..#04 libjni_latinime.so
F DEBUG   :   #11 com.android.inputmethod.latin.BinaryDictionary.access$getSuggestionsNative
F DEBUG   :   #24 com.android.inputmethod.latin.BinaryDictionary.getSuggestions
F DEBUG   :   #30 helium314.keyboard.latin.dictionary.ReadOnlyBinaryDictionary.getSuggestions
F DEBUG   :   #35 helium314.keyboard.latin.dictionary.DictionaryCollection.getSuggestions
F DEBUG   :   #38 helium314.keyboard.latin.DictionaryFacilitatorImpl.getSuggestions
F DEBUG   :   #49 helium314.keyboard.latin.DictionaryFacilitatorImpl$getSuggestionResults$1.invokeSuspend
F DEBUG   :   #53 kotlinx.coroutines.DispatchedTask.run

Cause (from reading the code)
DictionaryFacilitatorImpl.getSuggestionResults() queries the secondary dictionary groups in scope.launch {} on a background thread and waits for them only up to await(120, TimeUnit.MILLISECONDS) (reduced from 500 ms in 05023da). If a query takes longer, the next keystroke starts a new query on the same dictionary while the previous one is still running.

Both queries use the same DicTraverseSession (same session id). Its Java buffers (mInputCodePoints, mPrevWordCodePointArrays, ...) and the native session are shared. BinaryDictionary.getSuggestions() only synchronizes the session lookup in getTraverseSession(), not the native call, so two threads can run getSuggestionsNative() on the same native session at the same time.

Fix that works for us
Hold a lock on the session for the whole query in BinaryDictionary.getSuggestions():

val session = getTraverseSession(sessionId)
synchronized(session) {
    // fill the session buffers, call getSuggestionsNative(..., session.getSession(), ...), read the results
}

(and pass session.getSession() instead of calling getTraverseSession(sessionId) a second time). We haven't seen the crash since. I can send a PR once we've tested it a bit longer.

To Reproduce

  1. Languages & Layouts → German → Multilingual typing → add English (US). Install the main dictionaries for both.
  2. Type fast, or copy some text and tap the clipboard suggestion right away.
  3. Occasionally the keyboard crashes and restarts. It depends on timing, so it doesn't happen every time.

Expected behavior
No crash.

App version & Flavor
Found in GlassType, my fork based on LeanType 4.3.0 (d634e26), standard flavor. BinaryDictionary.getSuggestions() is unchanged in current main (0e673e1), and getSuggestionResults() now waits even shorter (120 ms).

Device Info

  • Model: Samsung Galaxy S23 Ultra (SM-S918B)
  • OS version: Android 17
主要语言
Kotlin
星标
1k
派生
59
平均合并
14 小时 9 分钟
30 天内合并 PR
56

环境准备

从这里开始

  1. 先读完整个 Issue，再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库，在一个分支上完成修改。
  4. 提交 Pull Request，并在描述里引用这个 Issue 编号。

LeanBitLab/LeanType 的其他 Issue

查看 LeanBitLab/LeanType 的全部 Issue

相似的 Issue

更多 Kotlin Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。