spin loop in client/threadedclient.py causes cpu use in idle processes
还没有人认领这个 Issue。
评估
- 难度
- 1/5
- 预计耗时
- 1 小时以内
- 新手友好度
- 45/100
- Issue 类型
- 文档
- 描述清晰度
- 描述清楚
- 活跃度
- 停滞
- 技术栈
- python
- 领域
- networking
调研方向
Open client/threadedclient.py and read WebSocketClient.run_forever(), then review the history reference to issue #109 for the timeout rationale. Done means the existing timeout and SIGINT behavior are clearly documented in a comment without changing the loop.
由索引模型根据 Issue 内容生成。
描述
In client.threadedclient, WebSocketClient has a method run_forever(). The body of the code is:
while not self.terminated:
self._th.join(timeout=0.1)
top was showing bunches of processes that weren't doing anything, which I eventually traced to this spin loop. Of course, my first thought was WTF? because there is no apparent need for a timeout here. I managed to trace the code through the github history and found a reference to issue #109
I suggest a comment something like this in this function:
# signals and threads are not friends in python. Without the timeout, you can't
# interrupt this function with SIGINT. The timeout ensures that we return to the
# main thread periodically, so a pending SIGINT can be processed. If this causes
# unreasonable CPU usage in your application, just override this method to not
# have a timeout, and don't try to interrupt it with SIGINT.
It is not clear to me that this is a problem for most users, but it was for me. I first noticed because the fans in my computer were speeding up even though my application wasn't doing anything. (I have lots of processes on standby.)
- 主要语言
- Python
- 星标
- 1.1k
- 派生
- 285
- PR 合并指标
- 30 天内没有已合并 PR
环境准备
这个项目没有提供开发容器、Dockerfile 或贡献指南，环境需要你自己搭建：先看它的 README，通用步骤见我们的新手贡献指南。
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
Lawouach/WebSocket-for-Python 的其他 Issue
-
难度 3/5 1-2 天 新手友好度 45/100
Lawouach/WebSocket-for-Python#300 ·
-
This project is not well maintained so be very very very patient!可能重新可做 @Lawouach 于 647 天前认领，目前没有进行中的 PR。 未关闭question
Lawouach/WebSocket-for-Python#297 · 2 条评论 · 已指派 1 人 ·
-
难度 4/5 3-5 天 新手友好度 20/100
Lawouach/WebSocket-for-Python#296 ·
-
Make the codes python 3 compatible可能重新可做 @auvipy 于 1054 天前认领，目前没有进行中的 PR。 未关闭
Lawouach/WebSocket-for-Python#280 · 1 条评论 · 已指派 1 人 ·
-
Setup new CI可能重新可做 @auvipy 于 1225 天前认领，目前没有进行中的 PR。 未关闭
Lawouach/WebSocket-for-Python#275 · 已指派 1 人 ·
查看 Lawouach/WebSocket-for-Python 的全部 Issue
相似的 Issue
-
bug status/needs-triage
难度 2/5 1-3 小时 新手友好度 86/100
prowler-cloud/prowler#12887 · 1 条评论 ·
维护者通常 1 天内回复
-
area: desktop platform: macos priority: p3 status: ready type: enhancement
难度 1/5 1 小时以内 新手友好度 92/100
use-agent-os/agent-os#3484 ·
维护者通常 2 天内回复
-
bug
难度 2/5 1-3 小时 新手友好度 86/100
open-telemetry/opentelemetry-python-contrib#5113 · 2 条评论 · 2 个 reaction ·
维护者通常 1 天内回复
-
external
难度 2/5 1-3 小时 新手友好度 68/100
langchain-ai/docs#6255 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 72/100
维护者通常 1 天内回复