Hacktoberfest 2026:维护者为十月标记出来的 issue,仍然开放、适合新手。 浏览 Hacktoberfest issue

[Audit] Fee-collection events are the only handler not wrapped in a transaction, and worker inconsistency compounds UX-visible drift

未关闭
#1,239 6 条评论 0 个 reaction 已指派 1 人 在 GitHub 查看

维护者通常 7 天内回复

@d1a-m3n 已经在做这个了。

开始于 2026年8月29日。

评估

这个 Issue 还没有评估数据。

描述

backend enhancement second-wave-audit Stellar Wave ux

Filed from the second-wave repository audit (issue 37/100). See the audit summary for full category context.

  • Location: backend/src/workers/soroban-event-worker.ts:1000-1060 (handleFeeCollected)
  • Problem: Unlike every other event handler in the file, this one performs its dedup check and its upsert as two separate top-level prisma calls instead of one prisma.$transaction, reopening a TOCTOU window the rest of the file was clearly designed to avoid.
  • Evidence: No $transaction wrapper, in contrast to sibling handlers in the same file.
  • Suggested implementation: Wrap the dedup-check + upsert in prisma.$transaction, matching the other handlers.
  • Acceptance criteria: A test simulating two near-simultaneous fee-collected events for the same tx confirms exactly one StreamEvent row is created.
  • Difficulty: S
  • Expected impact: Closes a duplicate-fee-event race visible to anyone reconciling fee revenue from the API.
主要语言
TypeScript
星标
18
派生
250
平均合并
5 天 5 小时
30 天内合并 PR
83

环境准备

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

LabsCrypt/flowfi 的其他 Issue

查看 LabsCrypt/flowfi 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。