Compiler plugin: refine `reorderColumnsBy` / `reorderColumnsByName` with `inFrameColumns`

未关闭
  • 哪里不对？
#2,139 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
25/100
Issue 类型
功能
描述清晰度
基本清楚
活跃度
活跃
技术栈
kotlin
领域
compilers, data

调研方向

Start with the ReorderColumnsByName interpreter in the Kotlin repository and the reorderColumnsByName / reorderColumnsBy overloads that take inFrameColumns. Step 1 depends on the dataframe-dev bump that includes #2130, so the change cannot be made until that lands. Done means the new interpreter declares inFrameColumns, the overload carries @Refine and @Interpretable, and the compile-time schema matches the runtime column order for nested frame columns.

由索引模型根据 Issue 内容生成。

描述

Compiler plugin

reorderColumnsByName(atAnyDepth, desc, inFrameColumns) and reorderColumnsBy(atAnyDepth, desc, inFrameColumns) { }
were added in #2130 without @Refine. With the compiler plugin, the result of such a call keeps the receiver's
compile-time schema, so its column order is not updated.

They are not refined because the ReorderColumnsByName interpreter in the Kotlin repository declares only
receiver, atAnyDepth and desc. An argument the interpreter does not declare makes interpret() return
null, and the plugin then materializes an empty schema, so accessors on the result stop compiling. An
interpreter name the plugin does not know has the same effect.

Steps:

  1. After dataframe-dev in the Kotlin repository includes #2130, add inFrameColumns support to the
    interpreter (a new interpreter, or val Arguments.inFrameColumns: Boolean by arg(defaultValue = Present(false))).
  2. Add @Refine / @Interpretable to the new reorderColumnsByName overload. Do this only once the minimal
    Kotlin version supported with the compiler plugin contains step 1; with an older plugin the call gets an
    empty schema.
  3. Optionally, refine reorderColumnsBy too. Like by / byDesc, its expression is arbitrary code.

Until the dataframe-dev bump, reorderColumnsByName() is interpreted with the old :core, which still
reorders the columns inside frame columns, so the compile-time schema of nested frame columns can differ
from the runtime one. Columns are accessed by name, so code keeps working.

主要语言
Kotlin
星标
1.1k
派生
87
平均合并
2 天 21 小时
30 天内合并 PR
40

环境准备

在 Codespaces 中打开

在浏览器里用你自己的 GitHub 账号启动这个项目的开发容器。

  • 没有 Dockerfile 或 Docker Compose 文件
  • 没有 Pull Request 模板
  • 阅读贡献指南

从这里开始

  1. 先读完整个 Issue，再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库，在一个分支上完成修改。
  4. 提交 Pull Request，并在描述里引用这个 Issue 编号。

Kotlin/dataframe 的其他 Issue

查看 Kotlin/dataframe 的全部 Issue

相似的 Issue

更多 Kotlin Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。