[LVS] Reading invalid SPICE netlist silently fails

未关闭
#2,166 2 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
42/100
Issue 类型
缺陷
描述清晰度
基本清楚
活跃度
停滞
技术栈
cpp, ruby
领域
tooling

调研方向

Start with the netlist.read call in src/lvs/lvs/built-in-macros/_lvs_netter.rb around line 951 and the exception-raising code in src/db/db/dbNetlistSpiceReader.cc around lines 485–511. Reproduce the issue with the SPICE netlist in the report and trace how parser errors cross the C++/Ruby interface. Done means the invalid input no longer fails silently and the error is handled appropriately.

由索引模型根据 Issue 内容生成。

描述

It seem that the LVS schematic function used to parse a spice file does not handle errors properly.

More specificaly, it seems the netlist.read call cannot fail:

https://github.com/KLayout/klayout/blob/ec5de0ffe83ed0e51c64473b0bef0c8bf140d87b/src/lvs/lvs/built-in-macros/_lvs_netter.rb#L951

Interestingly enough, exceptions are raised in the read function:

https://github.com/KLayout/klayout/blob/ec5de0ffe83ed0e51c64473b0bef0c8bf140d87b/src/db/db/dbNetlistSpiceReader.cc#L485-L511

The problems seems to come from the c++/ruby interface, where exceptions generated in c++ are not caught in ruby. Unfortunately, I do not have the skills to debug this much further.

A simple way to reproduce the error is to load the following SPICE file for an LVS comparison. You will see that only the first resistor is parsed, whereas the second is not present (due to the spice parser throwing on the "&%ç%&*+£à° line

.subckt top A B sub
R1 A B
"&%ç%&*+£à°
R2 A B
.ends
主要语言
C++
星标
1.2k
派生
305
平均合并
3 天 2 小时
30 天内合并 PR
11

环境准备

这个项目没有提供开发容器、Dockerfile 或贡献指南,环境需要你自己搭建:先看它的 README,通用步骤见我们的新手贡献指南。

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

KLayout/klayout 的其他 Issue

查看 KLayout/klayout 的全部 Issue

相似的 Issue

更多 C++ Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。