Array construction queries device properties on every allocation
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
- 难度
- 3/5
- 预计耗时
- 半天
- 新手友好度
- 65/100
- Issue 类型
- 重构
- 描述清晰度
- 描述清楚
- 活跃度
- 活跃
- 领域
- performance
调研方向
Start in check_eltype and _device_supports_bfloat16 in src/array.jl, and reuse the device_limits cache in src/oneAPIKernels.jl as a pattern. Run the benchmark script in the issue to get a baseline, then check _device_supports_bfloat16 in compilation.jl too. Done when the fp16, fp64 and bf16 flags are cached per device, the capability bits come from module_properties(dev).flags, the benchmark drops well below 1 µs, and test/runtests.jl still passes.
由索引模型根据 Issue 内容生成。
描述
check_eltype (src/array.jl), which runs on every oneArray construction, queries the driver each time it's called:
oneL0.module_properties(device()), twice (Float16 and Float64 checks);_device_supports_bfloat16(), which on devices that don't advertiseZE_bfloat16_conversions(everything except PVC with recent drivers) falls through tooneL0.properties(dev). That builds the full device-properties NamedTuple, including the nameStringand UUID.
On an Iris Xe (TGL, NEO 26.18) with oneAPI.jl master (fa0f23a2):
| call | median | allocs |
|---|---|---|
oneAPI.check_eltype(Float32) |
29.2 µs | 67 (3.4 KiB) |
oneL0.properties(dev) |
20.9 µs | 32 |
oneL0.module_properties(dev) |
2.6 µs | 15 |
check_eltype with cached capability flags |
0.08 µs | 1 |
Allocating and freeing a small array (unsafe_free!(oneArray{Float32}(undef, 16))) takes about 25 µs on an idle machine, so this check accounts for most of the cost of a small allocation. A profile shows most samples under check_eltype → _device_supports_bfloat16 → properties. Arrays allocated inside GPUArrays/AcceleratedKernels internals (reduction scratch space, similar) pay this cost as well.
Suggested fix: compute the per-device capability flags (fp16, fp64, bf16) once and cache them, like device_limits in src/oneAPIKernels.jl does (a Dict keyed by ZeDevice), or memoize properties/module_properties themselves, since they're static for a device. compilation.jl also calls _device_supports_bfloat16(dev), so it would benefit too.
While you're there: check_eltype (and test/runtests.jl) test fp16flags & ZE_DEVICE_MODULE_FLAG_FP16 and fp64flags & ZE_DEVICE_MODULE_FLAG_FP64. But fp16flags/fp64flags are ze_device_fp_flags_t (DENORM=1, INF_NAN=2, ...), not ze_device_module_flags_t, so these checks test the denorm/inf-nan bits. They give the right answer in practice (a device either reports no fp64 flags at all or reports the full set), but the capability bits are in module_properties(dev).flags, which is what device_limits already uses.
Benchmark script
using oneAPI, BenchmarkTools
const L0 = oneAPI.oneL0
dev = device()
@benchmark oneAPI.check_eltype(Float32)
@benchmark L0.module_properties($dev)
@benchmark L0.properties($dev)
const cache = Dict{L0.ZeDevice,NTuple{3,Bool}}()
caps(d=device()) = get!(cache, d) do
m = L0.module_properties(d)
(m.flags & L0.ZE_DEVICE_MODULE_FLAG_FP16 != 0,
m.flags & L0.ZE_DEVICE_MODULE_FLAG_FP64 != 0,
oneAPI._device_supports_bfloat16(d))
end
function check_cached(T)
Base.allocatedinline(T) || error()
fp16, fp64, bf16 = caps()
fp16 || (oneAPI.contains_eltype(T, Float16) && error())
fp64 || (oneAPI.contains_eltype(T, Float64) && error())
bf16 || (oneAPI.contains_eltype(T, Core.BFloat16) && error())
nothing
end
@benchmark check_cached(Float32)
- 主要语言
- Julia
- 星标
- 217
- 派生
- 37
- 平均合并
- 1 天 7 小时
- 30 天内合并 PR
- 33
环境准备
这个项目没有提供开发容器、Dockerfile 或贡献指南,环境需要你自己搭建:先看它的 README,通用步骤见我们的新手贡献指南。
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
JuliaGPU/oneAPI.jl 的其他 Issue
-
难度 4/5 3-5 天 新手友好度 25/100
维护者通常 1 天内回复
-
难度 5/5 一周以上 新手友好度 35/100
JuliaGPU/oneAPI.jl#663 · 1 个 reaction ·
维护者通常 1 天内回复
-
Track outstanding GPU work per allocation for host-accessible arrays可能已有人在做 @maleadt 于 2 天前认领。 未关闭
难度 5/5 一周以上 新手友好度 45/100
维护者通常 1 天内回复
-
难度 4/5 3-5 天 新手友好度 35/100
JuliaGPU/oneAPI.jl#607 · 1 条评论 ·
维护者通常 1 天内回复
-
难度 4/5 3-5 天 新手友好度 48/100
维护者通常 1 天内回复
查看 JuliaGPU/oneAPI.jl 的全部 Issue
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 72/100
oscar-system/GAP.jl#1455 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 65/100
JuliaAI/MLJTransforms.jl#85 ·
-
难度 2/5 1-3 小时 新手友好度 70/100
SciML/OrdinaryDiffEq.jl#4875 ·
维护者通常 4 天内回复
-
documentation
难度 2/5 1-3 小时 新手友好度 62/100
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 66/100
SciML/NonlinearSolve.jl#1372 ·
维护者通常 1 天内回复