[Refactoring proposal] Test app structure refactoring
还没有人认领这个 Issue。
评估
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 新手友好度
- 45/100
- Issue 类型
- 重构
- 描述清晰度
- 基本清楚
- 活跃度
- 停滞
- 技术栈
- rails, ruby
调研方向
首先阅读 test/fixtures/active_record.rb 和 test_helper.rb,梳理其中包含的 schema、模型、控制器、资源、路由、配置和 monkey-patches。将每种组件类型提取到提议的测试文件中,并从 test_helper.rb 中引入这些文件。当测试应用保持其行为不变,且其结构与提议的布局一致时,即视为完成。
由索引模型根据 Issue 内容生成。
描述
This issue is a (choose one):
- Problem/bug report.
- Feature request.
- Refactor proposal
- Request for support. Note: Please try to avoid submitting issues for support requests. Use Gitter instead.
Checklist before submitting:
- I've searched for an existing issue.
- I've asked my question on Gitter and have not received a satisfactory answer.
- I've included a complete bug report template. This step helps us and allows us to see the bug without trying to reproduce the problem from your description. It helps you because you will frequently detect if it's a problem specific to your project.
- The feature I'm asking for is compliant with the JSON:API spec.
Description
Currently, we put all kind of components of our test app in side test/fixtures/active_record.rb. It contains schema, models, controllers and resources. The file’s name is quite misleading since it contains more than active_record related stuffs. And it’s a 2000 lines file, a little bit too long.
And in the meantime, test_helper.rb has the routes, test configurations, monkey-patches and test app configurations.
As a new contributor, I need to spend more time to figure out the test setup under this structure.
So I suggest we can do a small refactoring, to extract and put different types of components into their own files. Like:
test
|——— schema.rb # for schema
|——— models.rb # for models
|——— controllers.rb # for controllers
|——— resources.rb # for resources
|——— routes.rb # for routes
|——— app.rb # for app configs
|——— test_helper.rb # test configs, monkey-patchings and requires
Now we can just include these component files inside test_helper.rb and it’ll be more easier for new contributors to understand the test app.
- 主要语言
- Ruby
- 星标
- 2.3k
- 派生
- 546
- PR 合并指标
- 30 天内没有已合并 PR
贡献指南
这个仓库没有索引到贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
JSONAPI-Resources/jsonapi-resources 的其他 Issue
-
难度 1/5 1 小时以内 新手友好度 85/100
-
难度 3/5 1-2 天 新手友好度 50/100
JSONAPI-Resources/jsonapi-resources#1488 · 1 条评论 ·
-
难度 4/5 3-5 天 新手友好度 42/100
JSONAPI-Resources/jsonapi-resources#1479 · 2 条评论 ·
-
难度 4/5 3-5 天 新手友好度 30/100
JSONAPI-Resources/jsonapi-resources#1477 · 3 条评论 · 1 个 reaction ·
-
难度 3/5 1-2 天 新手友好度 45/100
查看 JSONAPI-Resources/jsonapi-resources 的全部 Issue
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 70/100
-
bug
难度 1/5 1 小时以内 新手友好度 90/100
riscv/riscv-unified-db#2626 ·
-
Component: GLib
难度 2/5 1-3 小时 新手友好度 70/100
-
ds-drift
难度 2/5 1-3 小时 新手友好度 70/100
we-promise/sure#3693 ·
-
难度 2/5 1-3 小时 新手友好度 75/100
simp/pupmod-simp-simp#395 ·