Semantics of `mkFsPath` inconsistent between instances and vulnerable in IO
还没有人认领这个 Issue。
评估
- 难度
- 5/5
- 预计耗时
- 一周以上
- 新手友好度
- 35/100
- Issue 类型
- 缺陷
- 描述清晰度
- 基本清楚
- 活跃度
- 停滞
- 技术栈
- haskell
调研方向
首先阅读 FsPath 的描述以及 mkFsPath 和 fsPathToFilePath 入口点，比较真实文件系统和模拟文件系统的行为。定义并验证特定于平台的转义方式，以确保路径始终位于挂载点内，并在各个实例之间保持一致，包括 ["/", "etc", "passwd"] 示例。
由索引模型根据 Issue 内容生成。
描述
The semantics of mkFsPath are inconsistent between the real and simulated filesystem instances, as is documented in the description of FsPath.
This inconsistency makes it easy to write code that behaves differently depending on whether or not it runs on a real or simulated filesystem.
This makes it nigh-impossible to write code that is truly known to be invariant over what kind of filesystem it will be evaluated on, since the segments of the FsPath will be interpreted differently by the different instances.
Notably, the code mkFsPath ["/", "etc", "passwd"] will yield an FsPath that is well-behaved in the simulation, but yields a path to /etc/passwd when evaluated with the actual filesystem, regardless of the mount point.
tmpDir <- Dir.getTemporaryDirectory
let mountPoint = tmpDir </> "fs-sim"
let hasFS = ioHasFS (MountPoint mountPoint)
let passwd = mkFsPath ["/", "etc", "passwd"]
putStrLn (unsafeToFilePath passwd)
-- "/etc/passwd"
-- NOT: "/tmp/fs-sim/etc/passwd"
This breaks the encapsulation that the mount point is intended to introduce and introduces an attack vector that can be exploited by any FsPath created from user input or by an unreviewed version of a dependency.
Furthermore, fs-api significantly obfuscates the dangers here.
In my opinion, the fsPathToFilePath function that is used to interpreted FsPath on the real filesystem should escape all characters that have special meaning on the current platform in order to yield consistent behaviour across the API instances and better encapsulation.
- 主要语言
- Haskell
- 星标
- 2
- 派生
- 6
- PR 合并指标
- 30 天内没有已合并 PR
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 没有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
IntersectMBO/fs-sim 的其他 Issue
-
难度 2/5 1-3 小时 新手友好度 35/100
IntersectMBO/fs-sim#137 ·
-
难度 1/5 1 小时以内 新手友好度 45/100
IntersectMBO/fs-sim#136 ·
-
难度 2/5 1-3 小时 新手友好度 35/100
IntersectMBO/fs-sim#135 ·
-
No 0.4.1.0 tag未关闭
难度 1/5 1 小时以内 新手友好度 55/100
IntersectMBO/fs-sim#125 ·
-
难度 2/5 1-3 小时 新手友好度 48/100
IntersectMBO/fs-sim#122 ·
查看 IntersectMBO/fs-sim 的全部 Issue
相似的 Issue
-
难度 1/5 1 小时以内 新手友好度 75/100
-
15-minutes 5-minutes algorithm any-language beginner-friendly c cpp csharp easy go good first issue hacktoberfest help wanted java javascript kotlin python rust swift typescript
难度 1/5 1 小时以内 新手友好度 68/100
Huerte/algo-solutions-python#260 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 70/100
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 65/100
-
难度 2/5 1-3 小时 新手友好度 62/100
IntersectMBO/cardano-ledger#6276 ·
维护者通常 1 天内回复