Observer: the restored `converged` certifies an additive runaway when its window holds one zero step

未关闭
#2,428 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
5/5
预计耗时
一周以上
新手友好度
25/100
Issue 类型
缺陷
描述清晰度
基本清楚
活跃度
活跃
技术栈
c
领域
testing

调研方向

Read the reproduction and the pre-registration requirement in this issue, then inspect observer_slot_raw_diverging and the pinned HD1b and LE1b expectations in tests/test_halting_descent.eigs and tests/test_loop_exit.eigs. Decide whether a zero step may mask a same-sign runaway, record that decision, and update both tests to pin the chosen result.

由索引模型根据 Issue 内容生成。

描述

area:observer kind:silent-wrong

Found while settling the expectations of #2407 (the reveal's revert of converged and stable to v0.47.0's test).

Reproduction (the branch of #2407, and v0.47.0's test by the reference)

x is 1000000.0
x is 1000000.0
loop while not converged:
    x is x + 200.0
print of [__loop_exit__, __loop_iterations__, report of x]

prints ["normal", 9, "converged"]. Without the repeated first assignment the loop stalls after 100 iterations
(diverging). tools/reveal_restored_reference.py gives the same 9 in both modes (incumbent and branch), so this is
the incumbent's test, not a defect of the C port: every relative step is 200/1e6 = 2e-4 < 1e-3, and the raw same-sign
test (observer_slot_raw_diverging) requires every raw step of the window to share the newest step's sign, so the one
0.0 step at the window's oldest end makes it false. Round 3's diameter test refused it (diameter 1800 > 1e-3 * 1e6).

This changed two pinned expectations in #2407 (tests/test_halting_descent.eigs HD1b, tests/test_loop_exit.eigs
LE1b), now pinned at 9 / normal with a comment naming the blind spot.

Done when

  • A decision is recorded on whether a zero step in the window may hide a same-sign runaway from the raw test (the
    restored test's own rule, or a change judged as a new test on a fresh sealed set, as the pre-registration requires
    for any change after the reveal).
  • HD1b and LE1b pin the decided answer.

— Claude DevBox

主要语言
C
星标
3
派生
7
平均合并
3 小时 28 分钟
30 天内合并 PR
270

环境准备

在 Codespaces 中打开

在浏览器里用你自己的 GitHub 账号启动这个项目的开发容器。

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

InauguralSystems/EigenScript 的其他 Issue

查看 InauguralSystems/EigenScript 的全部 Issue

相似的 Issue

更多 C Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。