Split `forgelm/ingestion.py` into a sub-package (`_readers`, `_chunkers`, `_pipeline`) — deferred until the next change that adds a reader or a chunker
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
调研方向
Start with forgelm/ingestion.py and the _DEFERRED_SPLITS entry in tools/check_module_size.py, then read the deferral row in docs/roadmap/risks-and-decisions.md around line 80. The split must keep every public name importable from its current path, and test patch targets that named the old module need retargeting. Done means the module is a sub-package under the normal size ceiling, the deferral row is removed, and the CHANGELOG cites the ID. The issue is deferred until a reader or chunker change lands, so confirm that condition first.
由索引模型根据 Issue 内容生成。
描述
Deferred work ·
F-PR29-A1-06 / A1-07 / A1-08: ingestion.py· severity Low · cost ~4-8 h · recorded indocs/roadmap/risks-and-decisions.md:80
Summary
forgelm/ingestion.py is a deferred module split: PDF/DOCX/EPUB/TXT/Markdown readers, chunkers and the SFT-JSONL emitter share one file; the seams are already near-independent, which makes this the highest-value split per hour. The module-size guard holds it to a fatal no-growth budget, but nothing pays the debt down until someone takes the split.
Condition or budget
The next change that adds a reader or a chunker
State today (re-checked 2026-10-09)
2110 code lines against a budget of 2110 (1443 at PR #29).
Related
#667 and #668 track how the module-size guard counts lines and accepts budget raises; decide them before relying on a module's budget.
Acceptance criteria
- The module becomes a sub-package along the recorded seams, behaviour-neutral, with every public name still importable from its current path.
- Its
_DEFERRED_SPLITSentry is removed fromtools/check_module_size.pyand every resulting module is under the normal ceiling. - Test patch targets that named the old module are retargeted to the module that resolves the name at call time (the
forgelm/verify.pysplit found five that silently moved). - The row is removed from the deferral table and the CHANGELOG names its ID (the table's removal contract).
Recorded in docs/roadmap/risks-and-decisions.md (read at f94595f) and re-checked against the code on 2026-10-09. The row leaves that table only when the fix is on main, the CHANGELOG names its ID and any promised guard exists.
- 主要语言
- Python
- 星标
- 9
- 派生
- 1
- 平均合并
- 9 小时 14 分钟
- 30 天内合并 PR
- 37
环境准备
- 提供 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
HodeTech/ForgeLM 的其他 Issue
-
area: site bug good first issue severity: low wave: 4
难度 2/5 1-3 小时 新手友好度 75/100
HodeTech/ForgeLM#961 · 1 条评论 ·
维护者通常 1 天内回复
-
area: dev-tooling bug severity: low source: roadmap wave: 4
难度 2/5 1-3 小时 新手友好度 70/100
维护者通常 1 天内回复
-
Trend-tracking jq recipe prints evaluation_completed=false as 'n/a', because jq's // operator treats false like null (F-W1-DOCS-TRAIN-16)可能已有人在做 @yuefdev 于 2 天前认领。 未关闭documentation good first issue severity: low source: review-2026-09 wave: 4
难度 1/5 1-3 小时 新手友好度 80/100
维护者通常 1 天内回复
-
documentation severity: medium source: review-2026-09 wave: 3
难度 2/5 1-3 小时 新手友好度 72/100
维护者通常 1 天内回复
-
documentation good first issue severity: medium source: review-2026-09 wave: 3
难度 2/5 1-3 小时 新手友好度 68/100
维护者通常 1 天内回复
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 76/100
-
[Device Support Request] HOBEIAN ZG-204ZL (Tuya PIR motion sensor with illuminance)可能已有人在做 @lenucksi 今天认领。 未关闭
难度 2/5 1-3 小时 新手友好度 78/100
zigpy/zha-device-handlers#5493 ·
维护者通常 3 天内回复
-
难度 2/5 1-3 小时 新手友好度 78/100
drevendev/BeautifulRepo#42 ·
维护者通常 1 天内回复
-
enhancement good first issue
难度 2/5 1-3 小时 新手友好度 84/100
writerslogic/holographic-memory#93 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 66/100
antoine-tena/kiln#47 ·
维护者通常 1 天内回复