Site: the theme-locked --code-comment grey (#6a6f80) on the dark code surface is 3.8:1, below WCAG AA, in both themes (F-W1-SITE-06)
维护者通常 1 天内回复
评估
- 难度
- 2/5
- 预计耗时
- 1-3 小时
- 新手友好度
- 66/100
- Issue 类型
- 缺陷
- 描述清晰度
- 描述清楚
- 活跃度
- 活跃
- 技术栈
- css
- 领域
- accessibility, design
调研方向
从 site/css/style.css:56 的 --code-comment 令牌和 :115 的浅色主题代码块开始,该代码块使 --code-bg 保持深色。代码表面文本的规则位于 :1061、:1095、:1366、:1390、:1401 和 :2051。检查 #7a8090 与 #0d1018 的对比度(issue 报告为 4.8:1),然后确认所列的每种文本颜色在两种主题下都达到 4.5:1。请与 #683(CR-A18-055)协调,它涵盖相关的 --text-muted 令牌。
由索引模型根据 Issue 内容生成。
描述
Wave 4 · group W4 Module sweep · highest severity Low · 1 finding(s) · effort small
Summary
Code comments in code blocks and terminal mock-ups, and the small bar titles, language tags and copy buttons on the code surface, use --code-comment: #6a6f80 on --code-bg: #0d1018 — a 3.80:1 contrast ratio, below the 4.5:1 WCAG AA minimum for normal text. The code surface stays dark in light mode as well, so both themes are affected, while site/README.md:105 claims AA on both.
Primary finding
F-W1-SITE-06 — Code-surface comment and label text falls below the AA contrast floor
severity Low (rated Medium by the source review; Low here to match CR-A18-055 in #683, which it should be fixed with) · confidence high · computed from the CSS tokens
What happens. site/css/style.css:56 defines --code-comment; the light theme does not redefine it and keeps --code-bg dark (site/css/style.css:115). The token colours .terminal-body .comment (:1095), .code-block-body .comment (:1390) and the 0.78rem code-surface labels at :1061, :1366, :1401 and :2051. #683 (CR-A18-055) covers the --text-muted pairs, link and button colours and the README claim, but not this token, so fixing --text-muted leaves all of these below 4.5:1.
Where.
site/css/style.css:56(--code-comment)site/css/style.css:115(light theme keeps --code-bg dark)site/css/style.css:1095site/css/style.css:1390site/css/style.css:1061site/css/style.css:1366site/css/style.css:1401site/css/style.css:2051
Evidence (re-verified on 2026-10-09).
- sRGB relative-luminance contrast of
#6a6f80on#0d1018is 3.80:1; WCAG 2.1 SC 1.4.3 requires 4.5:1 for normal text (https://www.w3.org/WAI/WCAG21/Understanding/contrast-minimum). #7a8090reaches 4.82:1 on the same background, so a small token change clears the floor.
Recommended fix. Raise --code-comment to a grey that reaches at least 4.5:1 on #0d1018 (#7a8090 gives 4.8:1), or give the 0.78rem labels their own token, then re-check every text colour used on the code surface in both themes.
Related. #683 — CR-A18-055, the other contrast tokens and the README AA claim.
Acceptance criteria
- Every text colour used on the code surface reaches 4.5:1 against
--code-bgin both themes. - The finding is resolved or explicitly closed with a reason.
Found by the September 2026 independent review of ForgeLM against commit cab2947 and re-verified against development at f94595f on 2026-10-09. Code links point at cab2947; line numbers may have moved since. Finding IDs (F-W1-…) are stable references for this backlog.
- 主要语言
- Python
- 星标
- 9
- 派生
- 1
- 平均合并
- 17 小时 14 分钟
- 30 天内合并 PR
- 17
环境准备
- 提供 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
HodeTech/ForgeLM 的其他 Issue
-
area: site bug good first issue severity: low wave: 4
难度 2/5 1-3 小时 新手友好度 75/100
HodeTech/ForgeLM#961 · 1 条评论 ·
维护者通常 1 天内回复
-
area: dev-tooling bug severity: low source: roadmap wave: 4
难度 2/5 1-3 小时 新手友好度 70/100
维护者通常 1 天内回复
-
documentation good first issue severity: low source: review-2026-09 wave: 4
难度 1/5 1-3 小时 新手友好度 80/100
维护者通常 1 天内回复
-
documentation severity: medium source: review-2026-09 wave: 3
难度 2/5 1-3 小时 新手友好度 72/100
维护者通常 1 天内回复
-
documentation good first issue severity: medium source: review-2026-09 wave: 3
难度 2/5 1-3 小时 新手友好度 68/100
维护者通常 1 天内回复
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 88/100
NousResearch/hermes-agent#140958 ·
维护者通常 1 天内回复
-
bisect
难度 2/5 1-3 小时 新手友好度 72/100
dtcxzyw/llvm-bisect-service#548 ·
-
难度 2/5 1-3 小时 新手友好度 82/100
sallowayma-git/IELTS-practice#248 ·
维护者通常 1 天内回复
-
难度 1/5 1 小时以内 新手友好度 65/100
anthropics/claude-plugins-official#6763 · 10 条评论 · 10 个 reaction ·
维护者通常 3 天内回复
-
难度 2/5 1-3 小时 新手友好度 85/100
维护者通常 1 天内回复