Evaluate order-insensitive evidence comparison for PUT retry equality

未关闭
#7 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
5/5
预计耗时
一周以上
新手友好度
35/100
Issue 类型
功能
描述清晰度
需要澄清
活跃度
活跃

调研方向

Read the "Lifecycle" section of DESIGN.md and compare its rule for evidence ordering with sameEvidence in src/lifecycle.ts. The issue presents two incompatible behaviors but does not choose one; resolve that design decision first. Done means the chosen evidence-ordering rule is consistent between the design document and PUT retry equality.

由索引模型根据 Issue 内容生成。

描述

Problem

In src/lifecycle.ts, sameEvidence compares evidence items in caller-supplied array order when checking whether a PUT /Memory/<id> without If-Match is an idempotent retry of an existing memory, whereas tags, scopes, and supersedes are set-normalized (deduplicated and sorted).

DESIGN.md currently documents that evidence order is significant for idempotent retry equality.

Options

  1. Keep evidence ordered so primary-source citation ordering is preserved and significant for retry equality (as currently documented in DESIGN.md).
  2. Canonicalize evidence as a set when checking PUT retry equality (or normalize order on write) so reordered citations still qualify as an idempotent retry.

Refs: #5 (DESIGN.md "Lifecycle", src/lifecycle.ts).

Review-Deferral: 55e8a96f8586a5c3 severity=nit category=correctness

主要语言
JavaScript
星标
0
派生
0
平均合并
20 小时 29 分钟
30 天内合并 PR
28

环境准备

  • 没有 Dockerfile 或 Docker Compose 文件
  • 没有 Pull Request 模板
  • 阅读贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

HarperFast/agent-memory 的其他 Issue

查看 HarperFast/agent-memory 的全部 Issue

相似的 Issue

更多 JavaScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。