Windows: structure_test binary missing .exe extension causes "Open With" dialog instead of running tests
评估
- 难度
- 3/5
- 预计耗时
- 1-2 天
- 新手友好度
- 72/100
- Issue 类型
- 缺陷
- 描述清晰度
- 描述清楚
- 活跃度
- 冷清
- 技术栈
- bash, powershell
调研方向
从 container/repositories.bzl 开始,检查生成的 Windows 工具链 BUILD,以及解析 structure_test 的操作图。在 Windows Bazel 主机上使用 driver="tar" 重现 container_structure_test 目标,然后验证生成的启动器能够解析 .exe 路径并执行结构测试,而不是打开对话框。确认该目标报告实际的测试结果。
由索引模型根据 Issue 内容生成。
描述
Problem
On Windows, the structure_test binary downloaded by the Bazel toolchain has no file extension. When the generated .bat launcher script tries to invoke it (via bash.exe calling the binary, or via PowerShell's & operator), Windows does not recognise it as an executable.
Instead of running, Windows displays an "Open With" application picker dialog. The test process then returns exit code 0 (the dialog closes without error), so Bazel marks the test as PASSED without any structure tests having actually run.
Root cause
The Windows toolchain BUILD registers the binary without an extension:
# container/repositories.bzl — generated BUILD for windows_amd64
structure_test_toolchain(
name = "structure_test_toolchain",
structure_test = "structure_test" # no .exe
)
Windows requires an extension to recognise a file as directly executable. The binary is a valid PE (.exe), just named without the extension.
Reproduction
- Use
container_structure_testwithdriver = "tar"on a Windows Bazel host. - Run the generated test target.
- An "Open With" dialog appears briefly and disappears; the test reports
PASSED. - No structure tests were actually executed.
Fix
Symlink the binary to <name>.exe in the Bazel action graph when building on Windows. This is safe — the binary is a valid PE regardless of its name — and the generated launcher scripts use rlocation to resolve the path at runtime, so they automatically pick up the .exe copy.
is_windows = ctx.target_platform_has_constraint(ctx.attr._windows_constraint[...])
if is_windows and not test_bin.basename.endswith(".exe"):
test_bin_exe = ctx.actions.declare_file(test_bin.basename + ".exe")
ctx.actions.symlink(output = test_bin_exe, target_file = test_bin)
test_bin = test_bin_exe
A PR with this fix is attached.
- 主要语言
- Go
- 星标
- 2.5k
- 派生
- 213
- PR 合并指标
- 30 天内没有已合并 PR
环境准备
- 提供 Dockerfile 或 Docker Compose 文件
- 没有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
GoogleContainerTools/container-structure-test 的其他 Issue
-
难度 2/5 1-3 小时 新手友好度 78/100
-
allstar
难度 2/5 1-3 小时 新手友好度 65/100
GoogleContainerTools/container-structure-test#393 · 639 条评论 ·
-
难度 2/5 1-3 小时 新手友好度 68/100
GoogleContainerTools/container-structure-test#280 · 1 个 reaction ·
-
难度 4/5 3-5 天 新手友好度 45/100
-
难度 3/5 1-2 天 新手友好度 42/100
查看 GoogleContainerTools/container-structure-test 的全部 Issue
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 76/100
cloudflare/cloudflared#1783 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 66/100
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 78/100
维护者通常 1 天内回复
-
orchestration.migration.data.tasks.retry values are ignored by the 8.8 data migration job可能已有人在做 @irisfield 今天认领。 未关闭
难度 2/5 1-3 小时 新手友好度 78/100
camunda/camunda-platform-helm#7773 ·
维护者通常 1 天内回复
-
Add missing unit tests for IsAdmissionPolicyName and IsCertManagerResourceName可能已有人在做 @a1h8 今天认领。 未关闭
难度 2/5 1-3 小时 新手友好度 82/100
kubernetes-sigs/security-profiles-operator#3644 ·
维护者通常 1 天内回复