Security: executable archives downloaded over plain HTTP with hash verification disabled (nohash) - MITM code execution
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 新手友好度
- 52/100
调研方向
先从 lgsm/modules/core_steamcmd.sh、update_mta.sh 和 command_install_resources_mta.sh 中受影响的调用点开始,然后阅读 core_dl.sh 第 217 行和第 445 行附近的内容。比较 install_server_files.sh 中的校验和处理方式。完成的标准是:这些可执行归档在解压前使用 HTTPS 并进行校验和验证,同时 SteamCMD 和 MTA 的安装或更新路径仍能正常工作。
由索引模型根据 Issue 内容生成。
描述
Security report (responsible disclosure)
Executable archives fetched over plain HTTP with hash verification disabled (nohash) — MITM code execution
Affected files:
lgsm/modules/core_steamcmd.sh:17-19lgsm/modules/update_mta.sh:12-13lgsm/modules/command_install_resources_mta.sh:17-18
fn_fetch_file "http://media.steampowered.com/client/steamcmd_linux.tar.gz" "" "" "" "${tmpdir}" "steamcmd_linux.tar.gz" "nochmodx" "norun" "noforce" "nohash"
fn_dl_extract "${tmpdir}" "steamcmd_linux.tar.gz" "${steamcmddir}"
chmod +x "${steamcmddir}/steamcmd.sh"
fn_fetch_file "http://linux.mtasa.com/dl/multitheftauto_linux_x64.tar.gz" ... "force" "nohash"
Chain
curl -L over plain HTTP (core_dl.sh:445) on first steamcmd install and on MTA updates → nohash bypasses fn_dl_hash entirely (core_dl.sh:217) → archive extracted into ${steamcmddir} / ${serverfiles} → steamcmd.sh is chmod +x'd and executed by every subsequent update/start; MTA binaries run at server start, and MTA resources execute as Lua inside the game server.
Any network attacker on path (or DNS hijack — no TLS involved) replaces the payload and gets shell execution as the LinuxGSM user, re-triggered automatically by update crons.
Severity
High — unauthenticated network position → persistent code execution.
Suggested fix
Serve both URLs over HTTPS (both hosts support it), and pin sha256 checksums the way install_server_files.sh already does for its tarballs. The existing MD5 pinning there is better than nothing but sha256 would be the modern baseline.
- 主要语言
- Shell
- 星标
- 4.9k
- 派生
- 870
- 平均合并
- 22 小时 45 分钟
- 30 天内合并 PR
- 128
环境准备
在浏览器里用你自己的 GitHub 账号启动这个项目的开发容器。
- 没有 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
GameServerManagers/LinuxGSM 的其他 Issue
-
[Bug]: Zombie Master: Reborn runs in LAN mode and never answers queries on the current Source SDK 2013 build可能已有人在做 关联的 PR 仍在进行中或已合并。 未关闭command: install command: monitor command: start distro: Ubuntu engine: source game: Zombie Master: Reborn info: query regression: yes reproducible: always severity: high status: fixed in develop type: bug
难度 1/5 1 小时以内 新手友好度 88/100
GameServerManagers/LinuxGSM#5145 ·
维护者通常 1 天内回复
-
[Bug]: csserver metamod fails to load amxmodx after ubuntu 26.04 base image可能已有人在做 @dgibbs64 于 3 天前认领。 未关闭command: mods command: start distro: Ubuntu regression: yes reproducible: always severity: medium status: fixed in develop type: bug
难度 2/5 1-3 小时 新手友好度 70/100
GameServerManagers/LinuxGSM#5114 · 1 条评论 · 已指派 1 人 ·
维护者通常 1 天内回复
-
[Bug]: cs2server ignores the GSLT entered during install可能已有人在做 关联的 PR 仍在进行中或已合并。 未关闭command: install command: start distro: Debian engine: source2 game: Counter-Strike 2 regression: yes reproducible: always severity: high type: bug
难度 2/5 1-3 小时 新手友好度 82/100
GameServerManagers/LinuxGSM#5106 ·
维护者通常 1 天内回复
-
[Feature]: Rebuild the server archives hosted on linuxgsm.download with clean ownership, permissions and contents可能已有人在做 关联的 PR 仍在进行中或已合并。 未关闭command: install distro: Ubuntu engine: goldsrc engine: source game: Action Half-Life game: Call of Duty game: Call of Duty 4 game: Call of Duty: United Offensive game: Medal of Honor: Allied Assault game: Quake 2 game: Return to Castle Wolfenstein game: The Specialists game: Unreal Tournament 2004 game: Unreal Tournament 3 game: Unreal Tournament 99 game: Vampire Slayer game: Zombie Master: Reborn priority: low scope: multiple games type: feature
难度 5/5 一周以上 新手友好度 34/100
GameServerManagers/LinuxGSM#5144 ·
维护者通常 1 天内回复
-
[Feature]: Install and update QuakeWorld from qwserver-build releases可能已有人在做 @dgibbs64 于 1 天前认领。 未关闭command: install command: update distro: Ubuntu engine: quake game: Quake World priority: low scope: single game type: feature
难度 4/5 3-5 天 新手友好度 35/100
GameServerManagers/LinuxGSM#5143 ·
维护者通常 1 天内回复
查看 GameServerManagers/LinuxGSM 的全部 Issue
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 85/100
维护者通常 1 天内回复
-
area:docs phase:release priority:p0 type:test
难度 2/5 1-3 小时 新手友好度 66/100
-
premises-missing
难度 2/5 1-3 小时 新手友好度 78/100
WingedGuardian/GENesis-AGI#3917 ·
维护者通常 1 天内回复
-
area: infrastructure bug priority: low
难度 2/5 1-3 小时 新手友好度 78/100
snapotter-hq/SnapOtter#4573 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 67/100