Events are fired without arguments and event listeners are ignored
还没有人认领这个 Issue。
评估
- 难度
- 3/5
- 预计耗时
- 1-2 天
- 新手友好度
- 55/100
- Issue 类型
- 缺陷
- 描述清晰度
- 描述清楚
- 活跃度
- 停滞
- 技术栈
- javascript
- 领域
- web-dev
调研方向
Start in IdentityProxyXHR.js around lines 94-96 and reproduce the issue with XMLHttpRequest listeners registered through addEventListener and the onload shorthand. The change is complete when registered event listeners are invoked and callbacks receive the relevant event arguments, including progress and load events.
由索引模型根据 Issue 内容生成。
描述
This code simply executes xhr.onreadystatechange, xhr.onload and xhr.onloadend. There's a lot of different ways how events can be registered and fired (e.g. if one adds listeners with xhr.addEventListener(...). This means that if you don't register your listeners with one of the three shorthands, they are never fired.
Also, the mentioned code calls the callbacks without event arguments:
https://developer.mozilla.org/en-US/docs/Web/API/XMLHttpRequest/readystatechange_event
https://developer.mozilla.org/en-US/docs/Web/API/XMLHttpRequest/loadend_event
https://developer.mozilla.org/en-US/docs/Web/API/XMLHttpRequest/load_event
This leads to consumers not being able to access these events in their registered callbacks, which leads to exceptions if they do so. A very simple reproducer:
const x = new XMLHttpRequest();
x.open("GET", location.href);
x.addEventListener("progress", (event) => {
console.log(`progress: ${event.loaded * 100/event.total} %`);
});
x.addEventListener("load", (event) => {
console.log(`loaded ${event.loaded} bytes`);
});
x.send();
In this scenario, none of the events are fired. if you replace the addEventListener calls with the shorthands, you can see that only load is called without the event argument (progress is not called whatsoever):
x.onprogress = (event) => {
console.log(`progress: ${event.loaded * 100/event.total} %`);
};
x.onload = (event) => {
console.log(`loaded ${event.loaded} bytes`);
};
- 主要语言
- JavaScript
- 星标
- 52
- 派生
- 16
- PR 合并指标
- 30 天内没有已合并 PR
环境准备
这个项目没有提供开发容器、Dockerfile 或贡献指南,环境需要你自己搭建:先看它的 README,通用步骤见我们的新手贡献指南。
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
ForgeRock/appAuthHelper 的其他 Issue
-
Cannot read properties of undefined (reading 'clientId'): appAuthHelperFetchTokensBundle.js:46:635未关闭
难度 3/5 1-2 天 新手友好度 38/100
ForgeRock/appAuthHelper#67 ·
-
难度 5/5 一周以上 新手友好度 25/100
ForgeRock/appAuthHelper#64 ·
-
难度 5/5 一周以上 新手友好度 25/100
ForgeRock/appAuthHelper#62 ·
-
难度 4/5 3-5 天 新手友好度 35/100
ForgeRock/appAuthHelper#60 ·
-
难度 3/5 1-2 天 新手友好度 25/100
ForgeRock/appAuthHelper#59 ·
查看 ForgeRock/appAuthHelper 的全部 Issue
相似的 Issue
-
t0ggles
难度 2/5 1-3 小时 新手友好度 70/100
nolimits4web/swiper#8240 · 1 条评论 ·
-
netbox status: backlog topic: testing type: housekeeping
难度 2/5 1-3 小时 新手友好度 70/100
netbox-community/netbox#23395 ·
维护者通常 1 天内回复
-
bug
难度 2/5 1-3 小时 新手友好度 68/100
维护者通常 1 天内回复
-
[scanner] check:spelling skips blog/ — posts and author metadata are never spell-checked可能已有人在做 @hivecommons-hive 今天认领。 未关闭agent/scanner bug hive/covered-by-pr hive/hosted-available-lke648397-260827-5n31
难度 1/5 1 小时以内 新手友好度 72/100
维护者通常 1 天内回复
-
Edit: HTVKey.vn未关闭channels:edit check:passed
难度 1/5 1 小时以内 新手友好度 72/100
维护者通常 6 天内回复